builder: ensure libnetwork state files do not leak#41863
Merged
Conversation
thaJeztah
added
area/builder
thaJeztah
requested changes
Jan 7, 2021
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
net-leak-fix
branch
from
January 7, 2021 19:17
cdd2573 to
7c7e168
Compare
Member
|
@cpuguy83 @tiborvass PTAL |
Member
|
Arf; cherry-picking this one, and notice that the PR description is only on GitHub, not as commit message 😞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently calling
sandbox.Deleteis not enough to remove all the libnetwork state files, eg. the hosts and resolv.conf file. So to avoid leaks clean up the sandbox state directory manually.Looking at what happens on regular containers, it seems that netns is cleaned up by finalized and not directly by code. This could be investigated more in the future as could leak on restarts etc. The hosts/resolv.conf is stored in container state directory and cleaned up with container afaics.
Signed-off-by: Tonis Tiigi [email protected]