Add shim config for custom runtimes for plugins#41854
Merged
thaJeztah merged 1 commit intoJan 21, 2021
Merged
Conversation
3 tasks
cpuguy83
force-pushed
the
for-linux-1169-plugins-custom-runtime-panic
branch
from
5ec84c5 to
f197d3a
Compare
thaJeztah
added
area/runtime
cpuguy83
force-pushed
the
for-linux-1169-plugins-custom-runtime-panic
branch
from
f197d3a to
1f9d799
Compare
tiborvass
approved these changes
Jan 7, 2021
3 tasks
This fixes a panic when an admin specifies a custom default runtime, when a plugin is started the shim config is nil. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
for-linux-1169-plugins-custom-runtime-panic
branch
from
1f9d799 to
2903863
Compare
Member
|
s390x failure is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a panic when an admin specifies a custom default runtime,
when a plugin is started the shim config is nil.
Fixes docker/for-linux#1169
fixes docker/for-linux#1185