Reject null manifests during tar import#41842
Merged
Merged
Conversation
thaJeztah
approved these changes
Jan 21, 2021
Member
thaJeztah
left a comment
There was a problem hiding this comment.
SGTM
@tonistiigi @tianon PTAL
Member
|
This feels conceptually really similar to #41701 - does it make sense to add a unit test for this one? 😇 🙏 |
Contributor
Author
|
PTAL @tianon I parted out validation into it's own function - testing |
Member
|
Looks like you forgot to sign-off the second commit, causing CI to fail. Feel free to squash the commits (probably makes sense to combine them in a single commit) |
Signed-off-by: Josh Chorlton <[email protected]>
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
I was using kaniko to build images, which erroneously produced a tarball with a manifest containing
null. Surprisingly, docker accepted the manifest but... didn't do anything.This is not outlined in the docker spec, but I believe
nullmanifests should be rejected ([]is okay!). It would have saved me a bunch of time, and I can't imagine anyone intentionally importingnullas an image (even[]is questionable).This change rejects null manifests. For a quick brief on how go JSON decodes null and [], see:
https://play.golang.org/p/kGuoI0x1xyc
- How I did it
I just added a check for a nil manifest
- How to verify it
I followed the guide to get a dev env running, then:
- Description for the changelog
reject tarballs with
nullmanifests on import- A picture of a cute animal (not mandatory but encouraged)
