cmd/dockerd: sd_notify STOPPING=1 when shutting down#41832
Merged
Conversation
Signal systemd when we start shutting down to complement the "READY" notify that was originally implemented in 97088eb From [sd_notify(3)](https://www.freedesktop.org/software/systemd/man/sd_notify.html#STOPPING=1) > STOPPING=1 > Tells the service manager that the service is beginning its shutdown. This is useful > to allow the service manager to track the service's internal state, and present it to > the user. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/enhancement
tianon
approved these changes
Dec 22, 2020
tianon
left a comment
tianon
left a comment
Member
There was a problem hiding this comment.
Nice, I like it!
(https://www.freedesktop.org/software/systemd/man/sd_notify.html is an interesting/useful read on the topic)
AkihiroSuda
approved these changes
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal systemd when we start shutting down to complement the "READY" notify
that was originally implemented in 97088eb (#3060; related to #2322)
From sd_notify(3)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)