Fix service job mode filter#41806
Merged
Merged
Conversation
Oops. Signed-off-by: Drew Erny <[email protected]>
AkihiroSuda
approved these changes
Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Previously, filtering based on mode would fail with jobs because users expect to filter on mode
replicated-joborglobal-job, but the filtering code was checking forreplicatedjoborglobaljob. Now, the filter matches the correct mode string.- How I did it
Added two dashes.
- How to verify it
Look and behold, the strings are now correct.
- Description for the changelog
Fixed filtering for
replicated-jobandglobal-jobService modes.