Makefile: switch to POSIX mode to handle errors#41741
Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
Closed
Makefile: switch to POSIX mode to handle errors#41741thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah wants to merge 1 commit intomoby:masterfrom
Conversation
> .POSIX > > The application shall ensure that this special target is specified without prerequisites > or commands. If it appears as the first non-comment line in the makefile, make shall > process the makefile as specified by this section; otherwise, the behavior of make is > unspecified. Running the makefile with `.POSIX` runs shells with the `-e` options, which helps with handling errors; without this, make can complet "succesfully", even if shell commands in a target fail. Note that this patch does not change behavior on macOS, which runs an older version of GNU make that does not support these options. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
@tianon @tiborvass PTAL |
tiborvass
approved these changes
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to docker/docker-ce-packaging#510 and moby/sys#19 (comment)
also see docker/docker-ce-packaging#504 (comment)
Running the makefile with
.POSIXruns shells with the-eoptions, which helps withhandling errors; without this, make can complet "succesfully", even if shell commands
in a target fail.
Note that this patch does not change behavior on macOS, which runs an older version of
GNU make that does not support these options.
Signed-off-by: Sebastiaan van Stijn [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)