Add feature: remove spare network url#41728
Closed
xibolun wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Peng GanYu <[email protected]>
thaJeztah
requested changes
Nov 30, 2020
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
Thanks for contributing; I don't think this should be removed (see my comment inline)
| r.routes = []router.Route{ | ||
| // GET | ||
| router.NewGetRoute("/networks", r.getNetworksList), | ||
| router.NewGetRoute("/networks/", r.getNetworksList), |
Member
Member
There was a problem hiding this comment.
What I usually do in these cases, is using the "git blame" view on GitHub to see what commit changed the line, for example, in this case: https://github.com/moby/moby/blame/b9a3a51ac562b40f658645db1a34bedb894edddf/api/server/router/network/network.go#L33
From that, you can see the commit details 6ad4bf0, which describes why the change was made, and also has a link to the pull request related to it;
Member
|
Opened #41729 to add a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
it may be a mistake at
api/server/router/network/network.go; there is a spare network url;- How I did it
remove the url of
/networks/- How to verify it
- Description for the changelog
remove spare network url
- A picture of a cute animal (not mandatory but encouraged)
^ ^