Move container exit state to after cleanup.#41698
Merged
Merged
Conversation
thaJeztah
changed the title
Member
|
discussing in the maintainers meeting; putting this on hold for directly after 20.10.0, to give it some time for testing |
thaJeztah
changed the title
Before this change, there is no way to know if container (runtime) resources have been cleaned up unless you actually remove the container. This change allows callers of the wait API or the events API to know that all runtime resources for the container are released (e.g. IP addresses). Signed-off-by: Brian Goff <[email protected]>
tianon
force-pushed
the
fix_shutdown_handling
branch
from
January 28, 2021 19:29
c91fdd5 to
e192ce4
Compare
thaJeztah
added
status/4-merge
area/daemon
Member
|
Failures are unrelated |
Member
|
Discussing in the maintainers meeting, and we'll keep this one for 21.xx, so removing the cherry-pick label for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, there is no way to know if container (runtime)
resources have been cleaned up unless you actually remove the container.
This change allows callers of the wait API or the events API to know
that all runtime resources for the container are released (e.g. IP
addresses).