vendor: golang.org/x/crypto c1f2f97bffc9c53fc40a1a28a5b460094c0050d9 #41690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
thaJeztah
commented
Nov 18, 2020
Comment on lines
+145
to
+147
Member
Author
There was a problem hiding this comment.
Not sure if this affects us; looks like there already was a similar error further down
full diff: golang/crypto@75b2880...c1f2f97 relevant changes: - pkcs12: document that we use the wrong PEM type - pkcs12: drop PKCS#12 attributes with unknown OIDs - ocsp: Improve documentation for ParseResponse and ParseResponseForCert other changes (not in vendor); - ssh: improve error message for KeyboardInteractiveChallenge - ssh: remove slow unnecessary diffie-hellman-group-exchange primality check - ssh/terminal: replace with a golang.org/x/term wrapper - Deprecates ssh/terminal in favor of golang.org/x/term - ssh/terminal: add support for zos - ssh/terminal: bump x/term dependency to fix js/nacl - nacl/auth: use Size instead of KeySize for Sum output - sha3: remove go:nocheckptr annotation Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
bump_crypto
branch
from
dff9a84 to
fa592fa
Compare
Member
Author
|
merging this one into #41688, because buildkit uses some new packages from this dependency, and otherwise we may get incorrect vendoring if the PR's are merged out of order |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some parts being deprecated, but looks like those are not used in this codebase. There are some other changes in the diff, so thought I'd open a PR anyway 😅
full diff: golang/crypto@75b2880...c1f2f97
relevant changes:
other changes (not in vendor);
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)