Added fuzzer#41682
Open
AdamKorcz wants to merge 2 commits into
Open
Conversation
Member
|
Looks like you missed adding a dco sign-off in the commit message; https://github.com/moby/moby/pull/41682/checks?check_run_id=1413561891 can you amend the commit, and add a signed-off-by line? (let me know if you need help with that) |
Signed-off-by: AdamKorcz <[email protected]>
Contributor
Author
|
Thank you very much for your fast reply @thaJeztah. I managed to get the sign-off added. The error message from DCO was very helpful. |
Signed-off-by: AdamKorcz <[email protected]>
AkihiroSuda
reviewed
Nov 17, 2020
Contributor
Author
|
If there is anything I can do from my side, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADD FUZZER FOR
/IMAGE/STORE.GO- What I did
Added a fuzzer to
/image/with the purpose of integrating Docker into oss-fuzz.The fuzzer passes pseudo-random test inputs into the target application - in this case the target is Create in
/image- with the goal of uncovering bugs and vulnerabilities.The fuzzer is implemented by way of go-fuzz.
- How to verify it
My suggestion at this point is to setup continuous fuzzing through oss-fuzz. I have tested the fuzzer in this PR on oss-fuzz's infrastructure, and it runs fine on there. This integration does not require this fuzzer to be merged first, but a consent on integrating Docker would be required.
Setting up continuous fuzzing will allow Google to run the fuzzers and notify maintainers if and when a bug is found.
Oss-fuzz has a 90 day public disclosure policy.
As a reference, continuous fuzzing contributed to finding this CVE in Kubernetes.
- Description for the changelog
Added a go-fuzz fuzzer for /image/store.go
Signed-off-by: Adam Korczynski [email protected]