pkg/mount: fix compile failure on Windows (move linux-only stubs0#41637
pkg/mount: fix compile failure on Windows (move linux-only stubs0#41637thaJeztah wants to merge 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
@cpuguy83 @AkihiroSuda @TBBle ptal |
|
I have almost the same change sitting here, except I moved the non-Windows things into a deprecated_unix.go to match the Anyway, this LGTM, assuming CI passes now. I'm still looking into why the failing unit tests didn't fail the pipeline... Oops, another one to fix: |
If you have a branch with those changes; feel free to push as a PR, and I'll close this one 👍
Ah boo! My IDE didn't show up that one 😞 |
|
(these stubs are mostly to provide a slightly smoother transition for users to switch to the new location, and we don't plan to continue maintaining them after 20.10, as mentioned) |
|
I don't have those changes pushed in a PR yet (I just did them locally while waiting for Jenkins), since I'm trying to validate my "fix the false-pass" changes first. But I'm happy to carry that through, and fix the other failure too. Currently in #41636 but I would break out the CI/test fixes separately from that PR once I know they work. |
|
I went ahead and pushed a PR to fix this, and the false-passes, in #41636 |
|
Would it be ok to move the last two commits to a separate? Think we should be able to move faster to keep the PR focussed on a single fix /me ducks |
|
Sorry, I linked the wrong PR. I meant #41638, which is just the CI fixes. |
|
oh, thanks! |
|
closing in favour of #41638 |
2 participants
Fixes the compile failure introduced in #41458, but somehow didn't cause Windows CI to report a failure 😞 #41458 (comment)
For reference: I didn't look too closely if we're now stubbing all functions that were previously available on Windows; we're planning on removing these stubs altogether, and most of these should not be called on Windows (as they were non-functional or produced an error)