Cleanup v1 registry code that is not used for searching#41599
Merged
tiborvass merged 6 commits intomoby:masterfrom Oct 28, 2020
Merged
Cleanup v1 registry code that is not used for searching#41599tiborvass merged 6 commits intomoby:masterfrom
tiborvass merged 6 commits intomoby:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
There's no need to parse or validate the default registry, as it's a constant value. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This test was added in 0fc1169 as a regression test for saving credentials by the CLI. However, the CLI code is no longer in this repository, so it was no longer testing anything. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/distribution
thaJeztah
commented
Oct 28, 2020
Comment on lines
4
to
5
Member
Author
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
cleanup_some_v1_stuff
branch
from
50ec5aa to
b90ef12
Compare
Member
Author
|
Whoop! this is green (with the exception of s390x, which is tracked through #41561). I'll kick CI once, to see if it goes green |
tiborvass
approved these changes
Oct 28, 2020
Member
Author
|
checked with @cpuguy83 if this conflicts with some of the registry work he was working on, but should not conflict, so this one should be ready to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details. This will likely conflict with #39371, which also removes the "fallback" errors, but I think that's causing that PR to fail (i.e. when using "insecure registries", and connecting to
https://fails, it should continue with the next endpoint).