Skip to content

Fix build errors on Windows#41590

Closed
sryze wants to merge 1 commit intomoby:masterfrom
sryze:windows-build-fix
Closed

Fix build errors on Windows#41590
sryze wants to merge 1 commit intomoby:masterfrom
sryze:windows-build-fix

Conversation

@sryze
Copy link

@sryze sryze commented Oct 26, 2020

- What I did

  1. Fixed Building Windows version fails #41519
  2. Fixed a build issue when building from the Docker MSYS shell (Docker Toolbox) on Windows - because the path contains a colon on Windows, the -v flag passed to docker would not work when running make win (inside the DOCKER_MOUNT variable).

- How I did it

  1. Added a call to env to make the eval command work inside the dind script
  2. Replaced CURDIR with a custom variable that is set to the value of $(pwd)

- How to verify it

Compile on Windows by running make win

- Description for the changelog

Fixed build errors on Windows hosts

Fixes moby#41519

Signed-off-by: Sergey Zolotarev <[email protected]>
@thaJeztah
Copy link
Member

@sryze are you having the same issue if you use Docker Desktop?

@sryze
Copy link
Author

sryze commented Oct 30, 2020

I haven't tried with Docker Desktop, sorry. I'm usually using the Toolbox because I also need VirtualBox to work.

@sryze
Copy link
Author

sryze commented Oct 30, 2020

BTW am I using the right command to build the Windows binaries (make win)? I have some trouble finding the output files - it looks like they are not being copied to the host....

@sryze
Copy link
Author

sryze commented Nov 1, 2020

I've just tried building with Docker Desktop (on Window 10) and here are the results:

  1. Building Windows version fails #41519 still happens
  2. The path bug is not reproducible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building Windows version fails

2 participants