ci: enable DockerPluginSuite (integration-cli) by thaJeztah · Pull Request #41559 · moby/moby

thaJeztah · 2020-10-16T10:41:18Z

This enables the following tests;

./integration-cli/docker_cli_plugins_test.go:31:func (ps *DockerPluginSuite) TestPluginBasicOps(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:59:func (ps *DockerPluginSuite) TestPluginForceRemove(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:119:func (ps *DockerPluginSuite) TestPluginInstallDisable(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:147:func (ps *DockerPluginSuite) TestPluginSet(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:194:func (ps *DockerPluginSuite) TestPluginInstallArgs(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:209:func (ps *DockerPluginSuite) TestPluginInstallImage(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:223:func (ps *DockerPluginSuite) TestPluginEnableDisableNegative(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:242:func (ps *DockerPluginSuite) TestPluginCreate(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:271:func (ps *DockerPluginSuite) TestPluginInspect(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:329:func (ps *DockerPluginSuite) TestPluginIDPrefix(c *testing.T) {
./integration-cli/docker_cli_plugins_test.go:383:func (ps *DockerPluginSuite) TestPluginListDefaultFormat(c *testing.T) {

thaJeztah · 2020-10-16T10:59:45Z

ARGH CI is failing, because it looks like some vanity domain went AWOL;

https://ci-next.docker.com/public/blue/organizations/jenkins/moby/detail/PR-41559/1/pipeline/207

[2020-10-16T10:48:26.792Z] #47 [golangci_lint 1/1] RUN --mount=type=cache,target=/root/.cache/go-build ...
[2020-10-16T10:48:26.792Z] #47 139.9 package 4d63.com/gochecknoglobals/checknoglobals: unrecognized import path "4d63.com/gochecknoglobals/checknoglobals" (parse https://4d63.com/gochecknoglobals/checknoglobals?go-get=1: no go-import meta tags ())

https://4d63.com/gochecknoglobals/checknoglobals?go-get=1: gives a 404

But https://4d63.com/gochecknoglobals/ exists (so import path should be 4d63.com/gochecknoglobals/ ??

thaJeztah · 2020-10-16T11:01:24Z

Looks like this broke it golangci/golangci-lint#1422

But also means that (again) we're somehow installing golang-ci-lint master, not the specified version 😞

thaJeztah · 2020-10-16T11:07:08Z

Need something similar to #41151 for golang-ci-lint

thaJeztah · 2020-10-16T11:41:02Z

Opened #41560 to fix CI

thaJeztah · 2020-10-16T15:56:22Z

Rebased to get the fix from #41560 in

cpuguy83 · 2020-10-16T17:11:49Z

Nice, failing as expected without #41533

thaJeztah · 2020-10-16T18:22:45Z

Ah, great that's what i wanted

thaJeztah · 2020-10-22T18:57:17Z

rebased

cpuguy83

LGTM

thaJeztah · 2020-10-26T15:00:55Z

This may be a genuine failure;

=== RUN   TestDockerPluginSuite/TestPluginInstallImage
    --- FAIL: TestDockerPluginSuite/TestPluginInstallImage (15.17s)
        docker_cli_plugins_test.go:220: assertion failed: expression is false: strings.Contains(out, `Encountered remote "application/vnd.docker.container.image.v1+json"(image) when fetching`)

Will have to update that test to see what the actual output is

cpuguy83 · 2020-10-26T16:29:39Z

integration-cli/docker_cli_plugins_test.go

cmp.Contains should take care of this.

docker_cli_plugins_test.go:221: assertion failed: string "Error response from daemon: application/vnd.docker.distribution.manifest.v1+prettyjws not supported\n" does not contain "Encountered remote \"application/vnd.docker.container.image.v1+json\"(image) when fetching"

Ah, yes, I can replace those in this file.

Is the output it received here (application/vnd.docker.distribution.manifest.v1+prettyjws not supported) the expected output? (So should the test just be updated to match the other error?) or is there a bug at hand?

🤷 This looks like a schema1 manifest?
Seems like the media type changed as is, and then we've also moved this to use containerd distribution instead of docker/distribution.

It probably doesn't make sense to even support schema1 manifests for plugins... but I guess we could tell it to convert for us.

neersighted · 2022-09-21T14:24:05Z

Closed for now as this CI-failing test is tracked in another issue and this step was removed from the Jenkinsfile

thaJeztah · 2023-08-25T13:23:33Z

Interesting; getting some panics on Jenkins

=== RUN   TestDockerAPISuite/TestContainerAPICommit
    docker_api_containers_test.go:448: assertion failed: 
        Command:  /usr/local/cli-integration/docker run --name=testapicommit busybox /bin/sh -c touch /test
        ExitCode: 2
        Error:    exit status 2
        Stdout:   
        Stderr:   panic: runtime error: invalid memory address or nil pointer dereference
        [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x426bc]
        
        goroutine 1 [running]:
        github.com/docker/cli/cli/command/container.runContainer(0x40000c0480, 0x40004261e0, 0x4000418500, 0x400000c090)
        	/go/src/github.com/docker/cli/cli/command/container/run.go:171 +0x4dc
        github.com/docker/cli/cli/command/container.runRun(0x40000c0480, 0x913638?, 0x40000c0480?, 0x7e507a?)
        	/go/src/github.com/docker/cli/cli/command/container/run.go:94 +0xc4
        github.com/docker/cli/cli/command/container.NewRunCommand.func1(0x4000424fc0?, {0x4000364d20?, 0x5?, 0x5?})
        	/go/src/github.com/docker/cli/cli/command/container/run.go:48 +0xd8
        github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).execute(0x4000424fc0, {0x40000c4020, 0x5, 0x5})
        	/go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:646 +0x380
        github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x40000db680)
        	/go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:742 +0x21c
        github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).Execute(...)
        	/go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:695
        main.main()
        	/go/src/github.com/docker/cli/cmd/docker/docker.go:168 +0x74
        
        goroutine 19 [IO wait]:
        internal/poll.runtime_pollWait(0xffff70e3a918, 0x72)
        	/usr/local/go/src/runtime/netpoll.go:306 +0xa0
        internal/poll.(*pollDesc).wait(0x40003f6880?, 0x4000447000?, 0x0)
        	/usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0x28
        internal/poll.(*pollDesc).waitRead(...)
        	/usr/local/go/src/internal/poll/fd_poll_runtime.go:89
        internal/poll.(*FD).Read(0x40003f6880, {0x4000447000, 0x1000, 0x1000})
        	/usr/local/go/src/internal/poll/fd_unix.go:167 +0x200
        net.(*netFD).Read(0x40003f6880, {0x4000447000?, 0x40000a6c28?, 0x158ac?})
        	/usr/local/go/src/net/fd_posix.go:55 +0x28
        net.(*conn).Read(0x40000be590, {0x4000447000?, 0x0?, 0x40000021a0?})
        	/usr/local/go/src/net/net.go:183 +0x34
        net/http.(*persistConn).Read(0x4000468900, {0x4000447000?, 0x15780?, 0x4000042060?})
        	/usr/local/go/src/net/http/transport.go:1943 +0x50
        bufio.(*Reader).fill(0x400046efc0)
        	/usr/local/go/src/bufio/bufio.go:106 +0xfc
        bufio.(*Reader).Peek(0x400046efc0, 0x1)
        	/usr/local/go/src/bufio/bufio.go:144 +0x60
        net/http.(*persistConn).readLoop(0x4000468900)
        	/usr/local/go/src/net/http/transport.go:2107 +0x140
        created by net/http.(*Transport).dialConn
        	/usr/local/go/src/net/http/transport.go:1765 +0x1154
        
        goroutine 20 [select]:
        net/http.(*persistConn).writeLoop(0x4000468900)
        	/usr/local/go/src/net/http/transport.go:2410 +0x9c
        created by net/http.(*Transport).dialConn
        	/usr/local/go/src/net/http/transport.go:1766 +0x119c
        
        goroutine 35 [syscall]:
        os/signal.signal_recv()
        	/usr/local/go/src/runtime/sigqueue.go:152 +0x30
        os/signal.loop()
        	/usr/local/go/src/os/signal/signal_unix.go:23 +0x1c
        created by os/signal.Notify.func1.1
        	/usr/local/go/src/os/signal/signal.go:151 +0x28
        
        
        Failures:
        ExitCode was 2 expected 0
        Expected no error
    --- FAIL: TestDockerAPISuite/TestContainerAPICommit (0.05s)

vvoland · 2023-08-25T13:41:50Z

This is just a cli panic when attachContainer returns with error in v17.06.2-ce.
It was fixed in v17.07 (docker/cli#303).

thaJeztah · 2023-08-25T14:02:29Z

Ah, thanks for that link! Can be fully ignored then (I thought I'd post it just in case there was something weird)

Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah added status/2-code-review area/testing area/plugins kind/bugfix PR's that fix bugs labels Oct 16, 2020

thaJeztah mentioned this pull request Oct 16, 2020

testing: Init plugin config when for tests #41533

Merged

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from d830503 to b55b2b8 Compare October 16, 2020 15:56

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from b55b2b8 to 6324bd2 Compare October 22, 2020 18:57

cpuguy83 approved these changes Oct 22, 2020

View reviewed changes

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from 6324bd2 to f20fac5 Compare October 26, 2020 15:06

cpuguy83 reviewed Oct 26, 2020

View reviewed changes

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch 2 times, most recently from fa78597 to 3ab3d62 Compare October 27, 2020 19:47

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from 3ab3d62 to f1b4043 Compare June 25, 2021 11:11

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from f1b4043 to ba011fc Compare July 27, 2021 13:49

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from ba011fc to e846383 Compare September 24, 2021 07:40

crazy-max mentioned this pull request Aug 25, 2022

ci: gha test workflow for integration and unit test #44034

Merged

neersighted closed this Sep 21, 2022

thaJeztah mentioned this pull request Oct 18, 2022

integration-cli: DockerPluginSuite: use gotest.tools compare utilities #44316

Merged

thaJeztah reopened this Aug 24, 2023

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from e846383 to f01482d Compare August 24, 2023 12:58

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from f01482d to 2d657cd Compare August 24, 2023 12:59

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from 2d657cd to c8e6159 Compare December 8, 2023 13:03

thaJeztah mentioned this pull request Dec 8, 2023

integration-cli: Update plugin test install image error #46902

Draft

thaJeztah changed the title ~~Jenkinsfile: enable DockerPluginSuite (integration-cli)~~ ci: enable DockerPluginSuite (integration-cli) Dec 8, 2023

ci: enable DockerPluginSuite (integration-cli)

5f1884b

Signed-off-by: Sebastiaan van Stijn <[email protected]>

thaJeztah force-pushed the Jenkinsfile_DockerPluginSuite branch from c8e6159 to 5f1884b Compare January 20, 2024 19:11

Conversation

thaJeztah commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaJeztah commented Oct 16, 2020

Uh oh!

thaJeztah commented Oct 16, 2020

Uh oh!

thaJeztah commented Oct 16, 2020

Uh oh!

thaJeztah commented Oct 16, 2020

Uh oh!

thaJeztah commented Oct 16, 2020

Uh oh!

cpuguy83 commented Oct 16, 2020

Uh oh!

thaJeztah commented Oct 16, 2020

Uh oh!

thaJeztah commented Oct 22, 2020

Uh oh!

cpuguy83 left a comment

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Oct 26, 2020

Uh oh!

cpuguy83 Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

thaJeztah Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

cpuguy83 Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

neersighted commented Sep 21, 2022

Uh oh!

thaJeztah commented Aug 25, 2023

Uh oh!

vvoland commented Aug 25, 2023

Uh oh!

thaJeztah commented Aug 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thaJeztah commented Oct 16, 2020 •

edited

Loading