testing: Init plugin config when for tests#41533
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 21, 2020
Merged
Conversation
This fixes a panic when running this test for me locally. Signed-off-by: Brian Goff <[email protected]>
Member
FWIW, I think these steps should run test-integration-cli on amd64, but split into two parallel steps; Lines 333 to 337 in ef6416f However, because they try to make the split, it looks like First one is; Second one is Checking what suites there are; grep -rnw ./integration-cli/ -e 'type .*Suite'
./integration-cli//check_test.go:146:type DockerSuite struct {
./integration-cli//check_test.go:174:type DockerRegistrySuite struct {
./integration-cli//check_test.go:201:type DockerSchema1RegistrySuite struct {
./integration-cli//check_test.go:228:type DockerRegistryAuthHtpasswdSuite struct {
./integration-cli//check_test.go:257:type DockerRegistryAuthTokenSuite struct {
./integration-cli//check_test.go:292:type DockerDaemonSuite struct {
./integration-cli//check_test.go:331:type DockerSwarmSuite struct {
./integration-cli//check_test.go:390:type DockerPluginSuite struct {
./integration-cli//docker_hub_pull_suite_test.go:20:type DockerHubPullSuite struct {
./integration-cli//docker_cli_network_test.go:9:type DockerNetworkSuite struct {
./integration-cli//docker_cli_external_volume_driver_test.go:39:type DockerExternalVolumeSuite struct { |
Member
|
Looks like |
Member
|
Opened #41559 |
thaJeztah
approved these changes
Oct 16, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
ping @tiborvass @tianon ptal
Member
|
ping @AkihiroSuda @tianon ptal |
Member
|
green enough as well; let's merge: thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #40932
This fixes a panic when running this test for me locally.
This is not panicing on CI because CI has
TEST_SKIP_INTEGRATION_CLI=1👎