Remove default oom score adj#41528
Merged
cpuguy83 merged 2 commits intomoby:masterfrom Oct 16, 2020
Merged
Conversation
This was referenced Oct 5, 2020
6d20523 to
c259b24
Compare
tianon
approved these changes
Oct 15, 2020
dockerd currently sets the oom-score-adjust itself. This functionality was added when we did not yet run dockerd as a systemd service. Now that we do, it's better to instead have systemd handle this. Keeping the option itself for situations where dockerd is started manually or without using systemd. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
rebased to get the CI fix from #41560 in |
c259b24 to
561b801
Compare
This was referenced Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
--oom-score-adjustto-500- What I did
This removes the default
-500oom-score-adjust from the daemon. The test utilities are updated to keep the old default, as our tests start the daemon manually (not through systemd)- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)