Skip to content

Conversation

@tao12345666333
Copy link
Contributor

@tao12345666333 tao12345666333 commented Aug 12, 2020

vendor.conf Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor.conf Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for match containerd's dependencies

Comment on lines +356 to +357
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SYS_OPENAT2 looks related to https://patchwork.kernel.org/patch/11167585/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let me take a look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've separated these commits.

And I will open a PR for add openat2 to our seccomp profile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #41353

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green, thanks!

@tao12345666333
Copy link
Contributor Author

[2020-08-14T16:08:59.782Z] === Failed
[2020-08-14T16:08:59.782Z] === FAIL: amd64.integration-cli TestDockerSuite/TestLogsFollowSlowStdoutConsumer (1.40s)
[2020-08-14T16:08:59.782Z]     --- FAIL: TestDockerSuite/TestLogsFollowSlowStdoutConsumer (1.40s)
[2020-08-14T16:08:59.782Z]         docker_cli_logs_test.go:243: assertion failed: error is not nil: exit status 1
[2020-08-14T16:08:59.782Z] 
[2020-08-14T16:08:59.782Z] === FAIL: amd64.integration-cli TestDockerSuite (1291.11s)

Flaky test #41276

tao12345666333 added a commit to tao12345666333/moby that referenced this pull request Aug 16, 2020
@thaJeztah thaJeztah merged commit ae8d371 into moby:master Aug 17, 2020
@thaJeztah thaJeztah added this to the 20.03.0 milestone Aug 17, 2020
@tao12345666333 tao12345666333 deleted the vendor-runc-rc92 branch August 17, 2020 15:35
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Aug 17, 2020
follow up to moby/moby#41344 (comment)

Signed-off-by: Jintao Zhang <[email protected]>
Upstream-commit: b8988c84751d440eaa2978df7bb89faeeb6a520c
Component: engine
thaJeztah pushed a commit to thaJeztah/docker that referenced this pull request Aug 24, 2020
follow up to moby#41344 (comment)

Signed-off-by: Jintao Zhang <[email protected]>
(cherry picked from commit b8988c8)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah pushed a commit to moby/profiles that referenced this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants