-
Notifications
You must be signed in to change notification settings - Fork 18.9k
vendor runc rc92 #41344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor runc rc92 #41344
Conversation
vendor.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
introduced by opencontainers/runc@a73ce38
vendor.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for match containerd's dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SYS_OPENAT2 looks related to https://patchwork.kernel.org/patch/11167585/
- should we have these vendor-bumps in a separate commit? (are they needed for 19.03.x?)
- do we need to add
openat2to our seccomp profile?moby/profiles/seccomp/seccomp_default.go
Line 224 in 0f41a77
"openat",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, let me take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've separated these commits.
And I will open a PR for add openat2 to our seccomp profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #41353
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
c153af0 to
c353c7c
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if green, thanks!
Flaky test #41276 |
follow up to moby#41344 (comment) Signed-off-by: Jintao Zhang <[email protected]>
follow up to moby/moby#41344 (comment) Signed-off-by: Jintao Zhang <[email protected]> Upstream-commit: b8988c84751d440eaa2978df7bb89faeeb6a520c Component: engine
follow up to moby#41344 (comment) Signed-off-by: Jintao Zhang <[email protected]> (cherry picked from commit b8988c8) Signed-off-by: Sebastiaan van Stijn <[email protected]>
follow up to moby/moby#41344 (comment) Signed-off-by: Jintao Zhang <[email protected]>
vendor containerd to v1.4.0-rc.1
full diff containerd/containerd@779ef60...v1.4.0-rc.1
vendor runc to v1.0.0-rc92
full diff opencontainers/runc@67169a9...ff819c7
golang/crypto@2aa609c...75b2880
golang/net@0de0cce...ab34263
golang/sys@9dae0f8...ed371f2