Skip to content

Bump Golang 1.13.15#41333

Merged
thaJeztah merged 1 commit into
moby:masterfrom
thaJeztah:bump_golang_1.13.15
Aug 13, 2020
Merged

Bump Golang 1.13.15#41333
thaJeztah merged 1 commit into
moby:masterfrom
thaJeztah:bump_golang_1.13.15

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Aug 10, 2020

Copy link
Copy Markdown
Member

full diff: golang/go@go1.13.14...go1.13.15

go1.13.15 (released 2020/08/06) includes security fixes to the encoding/binary
package. See the Go 1.13.15 milestone on the issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.13.15+label%3ACherryPickApproved

@thaJeztah
Bump Golang 1.13.15
2a6325e 
full diff: golang/go@go1.13.14...go1.13.15

go1.13.15 (released 2020/08/06) includes security fixes to the encoding/binary
package. See the Go 1.13.15 milestone on the issue tracker for details.

https://github.com/golang/go/issues?q=milestone%3AGo1.13.15+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Aug 10, 2020
Merged
@thaJeztah

thaJeztah commented Aug 11, 2020

Copy link
Copy Markdown
Member Author

Flaky test: #41338

=== RUN   TestDockerDaemonSuite/TestDaemonRestartUnlessStopped
    --- FAIL: TestDockerDaemonSuite/TestDaemonRestartUnlessStopped (6.14s)
        docker_cli_daemon_test.go:140: assertion failed: true (bool) != false (shouldRun bool): After daemon restart: container "exit" is running

And this one (not sure I've seen that specific test fail before, so pasting the output here);

=== RUN   TestDockerSuite/TestRunMutableNetworkFiles
    --- FAIL: TestDockerSuite/TestRunMutableNetworkFiles (0.02s)
        cli.go:29: assertion failed:
            Command:  /usr/local/cli/docker rm -fv e0285c03b1c8
            ExitCode: 1
            Error:    exit status 1
            Stdout:
            Stderr:   Error response from daemon: No such container: e0285c03b1c8


            Failures:
            ExitCode was 1 expected 0
            Expected no error

@thaJeztah

thaJeztah commented Aug 13, 2020

Copy link
Copy Markdown
Member Author

All green now; @cpuguy83 @tianon PTAL

@thaJeztah thaJeztah added this to the 20.03.0 milestone Aug 13, 2020
tianon
tianon approved these changes Aug 13, 2020
View reviewed changes

@tianon tianon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thaJeztah
thaJeztah merged commit 0906c7f into moby:master Aug 13, 2020
@thaJeztah
thaJeztah deleted the bump_golang_1.13.15 branch August 13, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes
@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

impact/changelog process/cherry-picked status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @tianon @AkihiroSuda