Skip to content

Update runc binary to v1.0.0-rc92#41317

Merged
thaJeztah merged 1 commit into
moby:masterfrom
tao12345666333:upgrade-runc-rc92
Aug 7, 2020
Merged

Update runc binary to v1.0.0-rc92#41317
thaJeztah merged 1 commit into
moby:masterfrom
tao12345666333:upgrade-runc-rc92

Conversation

@tao12345666333

@tao12345666333 tao12345666333 commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

full diff opencontainers/runc@v1.0.0-rc91...v1.0.0-rc92

This release contains a hotfix to solve a regression in v1.0.0-rc91 that
concerns Docker (this only affects Docker's vendoring of libcontainer,
not the usage of runc as the runtime):

Fix helpers used by Docker to correctly handle symlinks in /dev (when running
with --privileged containers).
As well as some other improvements:

Updates to CRIU support.
Improvements to cgroupfs performance and correctness.
Static Linking Notices
The runc binary distributed with this release are statically linked with
the following GNU LGPL-2.1 licensed libraries, with runc acting
as a "work that uses the Library":

libseccomp
The versions of these libraries were not modified from their upstream versions,
but in order to comply with the LGPL-2.1 (§6(a)), we have attached the
complete source code for those libraries which (when combined with the attached
runc source code) may be used to exercise your rights under the LGPL-2.1.

However we strongly suggest that you make use of your distribution's packages
or download them from the authoritative upstream sources, especially since
these libraries are related to the security of your containers.

@tao12345666333
tao12345666333 requested a review from tianon as a code owner August 6, 2020 05:40
@AkihiroSuda

AkihiroSuda commented Aug 6, 2020

Copy link
Copy Markdown
Member

We should also update vendor (after merging containerd/containerd#4459)

@tao12345666333

tao12345666333 commented Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

OK, when containerd/containerd#4459 is merged, I will update vendor.

@tao12345666333

tao12345666333 commented Aug 6, 2020

Copy link
Copy Markdown
Contributor Author

Flaky test: DockerDaemonSuite.TestDaemonRestartUnlessStopped #38720

[2020-08-06T08:40:18.667Z] === Failed

[2020-08-06T08:40:18.667Z] === FAIL: amd64.integration-cli TestDockerDaemonSuite/TestDaemonRestartUnlessStopped (6.20s)

[2020-08-06T08:40:18.667Z]     --- FAIL: TestDockerDaemonSuite/TestDaemonRestartUnlessStopped (6.20s)

[2020-08-06T08:40:18.668Z]         docker_cli_daemon_test.go:140: assertion failed: true (bool) != false (shouldRun bool): After daemon restart: container "exit" is running

[2020-08-06T08:40:18.668Z] 

[2020-08-06T08:40:18.668Z] === FAIL: amd64.integration-cli TestDockerDaemonSuite (316.56s)

@thaJeztah

thaJeztah commented Aug 6, 2020

Copy link
Copy Markdown
Member

kicked CI

@thaJeztah thaJeztah added this to the 20.03.0 milestone Aug 6, 2020
thaJeztah
thaJeztah approved these changes Aug 6, 2020
View reviewed changes

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tianon
tianon approved these changes Aug 6, 2020
View reviewed changes

@tianon tianon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

thaJeztah commented Aug 7, 2020

Copy link
Copy Markdown
Member

CI is a bit flaky looks like, but all green now

@thaJeztah
thaJeztah merged commit c997a49 into moby:master Aug 7, 2020
@tao12345666333
tao12345666333 deleted the upgrade-runc-rc92 branch August 8, 2020 23:43
@thaJeztah thaJeztah mentioned this pull request Aug 11, 2020
Closed
@thaJeztah thaJeztah mentioned this pull request Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianon tianon tianon approved these changes
@thaJeztah thaJeztah thaJeztah approved these changes
@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/runtime Runtime impact/changelog status/4-merge

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tao12345666333 @AkihiroSuda @thaJeztah @tianon