Simplify getUser() to use libcontainer built-in functionality#41290
Merged
Conversation
thaJeztah
added
area/runtime
Member
Author
|
@kolyshkin @AkihiroSuda ptal |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
thaJeztah
force-pushed
the
getuser_refactor
branch
from
July 29, 2020 20:06
3534237 to
4fe2ec5
Compare
kolyshkin
previously requested changes
Jul 29, 2020
thaJeztah
force-pushed
the
getuser_refactor
branch
3 times, most recently
from
August 5, 2020 11:06
44f9808 to
c73a695
Compare
Member
Author
|
@kolyshkin updated; PTAL |
Member
Author
|
@AkihiroSuda @cpuguy83 ptal |
AkihiroSuda
approved these changes
Aug 13, 2020
kolyshkin
reviewed
Aug 20, 2020
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
getuser_refactor
branch
from
September 9, 2020 11:26
c73a695 to
65a33d0
Compare
Member
Author
|
@kolyshkin updated; PTAL |
Member
Author
|
ping @kolyshkin PTAL <3 |
tiborvass
approved these changes
Sep 28, 2020
tiborvass
dismissed
kolyshkin’s stale review
September 29, 2020 00:00
nits partially resolved (and named return not necessary). Sorry but i need to dismiss your review to be able to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #41288