vendor: vishvananda/netns db3c7e526aae966c4ccfa6c8189b693d6ac5d202#41283
Merged
tiborvass merged 1 commit intomoby:masterfrom Jul 29, 2020
Merged
vendor: vishvananda/netns db3c7e526aae966c4ccfa6c8189b693d6ac5d202#41283tiborvass merged 1 commit intomoby:masterfrom
tiborvass merged 1 commit intomoby:masterfrom
Conversation
full diff: vishvananda/netns@0a2b9b5...db3c7e5 - Use golang.org/x/sys/unix instead of syscall - Set O_CLOEXEC when opening a network namespace - Fixes "the container‘s netns fds leak, causing the container netns to not clean up successfully after the container stops" - Allows to create and delete named network namespaces Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/networking
Member
Author
arkodg
approved these changes
Jul 28, 2020
Member
Author
|
@tiborvass PTAL |
tiborvass
approved these changes
Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: vishvananda/netns@0a2b9b5...db3c7e5
clean up successfully after the container stops"
- Description for the changelog