Merged
Conversation
thaJeztah
requested changes
Jul 24, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
oh! could you also add a note to https://github.com/moby/moby/blob/master/docs/api/version-history.md ? (for visibility)
Member
|
and perhaps if you have time, a PR to add it to https://github.com/docker/cli/blob/master/docs/deprecated.md |
Kernel memory limit is not supported on cgroup v2. Even on cgroup v1, kernel memory limit (`kmem.limit_in_bytes`) has been deprecated since kernel 5.4. torvalds/linux@0158115 Signed-off-by: Akihiro Suda <[email protected]>
Member
Author
|
updated |
AkihiroSuda
force-pushed
the
deprecate-kernel-memory
branch
from
1f7e3db to
b8ca7de
Compare
AkihiroSuda
added a commit
to AkihiroSuda/docker-cli
that referenced
this pull request
Jul 24, 2020
`docker run --kernel-memory` is being deprecated in moby/moby#41254 Signed-off-by: Akihiro Suda <[email protected]>
Member
Author
|
CLI docs: docker/cli#2652 |
AkihiroSuda
added a commit
to AkihiroSuda/docker-cli
that referenced
this pull request
Jul 24, 2020
`docker run --kernel-memory` is being deprecated in moby/moby#41254 Signed-off-by: Akihiro Suda <[email protected]>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jul 27, 2020
`docker run --kernel-memory` is being deprecated in moby/moby#41254 Signed-off-by: Akihiro Suda <[email protected]> Upstream-commit: 074a8dcff6a1cb2699645ccfca92e7dea09fee8e Component: cli
Member
Author
|
@cpuguy83 PTAL |
tiborvass
approved these changes
Jul 28, 2020
eiffel-fl
pushed a commit
to eiffel-fl/cli
that referenced
this pull request
Jul 28, 2020
`docker run --kernel-memory` is being deprecated in moby/moby#41254 Signed-off-by: Akihiro Suda <[email protected]>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Jul 28, 2020
full diff: http://github.com/docker/docker/compare/78e6ffd279b627ebba046b9675ff4849091d9cc3...0f41a77c6993ade605a639fb25994cfe5e1b3fe8 Relevant changes: - moby/moby#41234 vendor: update buildkit to 4d1f260e8 - various updates to swagger files - moby/moby#41249 Replace swarm Capabilites API with cap add/drop API - updates swarmkit to 035d564a3686f5e348d861ec0c074ff26854c498 - moby/moby#41254 Deprecate KernelMemory Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jul 29, 2020
full diff: http://github.com/docker/docker/compare/78e6ffd279b627ebba046b9675ff4849091d9cc3...0f41a77c6993ade605a639fb25994cfe5e1b3fe8 Relevant changes: - moby/moby#41234 vendor: update buildkit to 4d1f260e8 - various updates to swagger files - moby/moby#41249 Replace swarm Capabilites API with cap add/drop API - updates swarmkit to 035d564a3686f5e348d861ec0c074ff26854c498 - moby/moby#41254 Deprecate KernelMemory Signed-off-by: Sebastiaan van Stijn <[email protected]> Upstream-commit: 097d57314d12c5b2b8dd267353172e51948a25f1 Component: cli
akerouanton
pushed a commit
to akerouanton/cli
that referenced
this pull request
Jul 29, 2020
`docker run --kernel-memory` is being deprecated in moby/moby#41254 Signed-off-by: Akihiro Suda <[email protected]>
akerouanton
pushed a commit
to akerouanton/cli
that referenced
this pull request
Jul 29, 2020
full diff: http://github.com/docker/docker/compare/78e6ffd279b627ebba046b9675ff4849091d9cc3...0f41a77c6993ade605a639fb25994cfe5e1b3fe8 Relevant changes: - moby/moby#41234 vendor: update buildkit to 4d1f260e8 - various updates to swagger files - moby/moby#41249 Replace swarm Capabilites API with cap add/drop API - updates swarmkit to 035d564a3686f5e348d861ec0c074ff26854c498 - moby/moby#41254 Deprecate KernelMemory Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was referenced Sep 11, 2020
|
With this option gone, what is the correct method of protecting the host machine from fork-bombs running inside containers? |
Member
|
@jimaek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Deprecate Kernel Memory.
Kernel memory limit is not supported on cgroup v2. Even on cgroup v1, kernel memory limit (
kmem.limit_in_bytes) has been deprecated since kernel 5.4.torvalds/linux@0158115
Fix #41252
- How to verify it
- Description for the changelog
Deprecate KernelMemory (
docker run --kernel-memory)- A picture of a cute animal (not mandatory but encouraged)
🐧