Skip to content

vendor: update buildkit to 4d1f260e8#41234

Merged
cpuguy83 merged 1 commit intomoby:masterfrom
tonistiigi:update-buildkit-0720
Jul 23, 2020
Merged

vendor: update buildkit to 4d1f260e8#41234
cpuguy83 merged 1 commit intomoby:masterfrom
tonistiigi:update-buildkit-0720

Conversation

@tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Jul 20, 2020 •
edited by thaJeztah
Loading

full diffs:

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jul 20, 2020 

[2020-07-20T07:52:36.744Z] builder/builder-next/worker/worker.go:486:6: type `resolveImageConfig` is unused (unused)

[2020-07-20T07:52:36.744Z] builder/builder-next/adapters/containerimage/pull.go:59:6: exported type `Source` should have comment or be unexported (golint)

[2020-07-20T07:52:36.744Z] type Source struct {

[2020-07-20T07:52:36.744Z]      ^

[2020-07-20T07:52:36.744Z] builder/builder-next/adapters/containerimage/pull.go:75:1: exported method `Source.ID` should have comment or be unexported (golint)

[2020-07-20T07:52:36.744Z] func (is *Source) ID() string {

[2020-07-20T07:52:36.744Z] ^

[2020-07-20T07:52:36.744Z] builder/builder-next/adapters/containerimage/pull.go:125:1: exported method `Source.ResolveImageConfig` should have comment or be unexported (golint)

[2020-07-20T07:52:36.744Z] func (is *Source) ResolveImageConfig(ctx context.Context, ref string, opt llb.ResolveImageConfigOpt, sm *session.Manager, g session.Group) (digest.Digest, []byte, error) {

[2020-07-20T07:52:36.744Z] ^

[2020-07-20T07:52:36.744Z] builder/builder-next/adapters/containerimage/pull.go:167:1: exported method `Source.Resolve` should have comment or be unexported (golint)

[2020-07-20T07:52:36.744Z] func (is *Source) Resolve(ctx context.Context, id source.Identifier, sm *session.Manager) (source.SourceInstance, error) {

[2020-07-20T07:52:36.744Z] ^

[2020-07-20T07:52:36.744Z] builder/builder-next/worker/worker.go:385:1: exported method `Worker.Executor` should have comment or be unexported (golint)

[2020-07-20T07:52:36.744Z] func (w *Worker) Executor() executor.Executor {

[2020-07-20T07:52:36.744Z] ^

[2020-07-20T07:52:36.744Z] builder/builder-next/worker/worker.go:389:1: exported method `Worker.CacheManager` should have comment or be unexported (golint)

[2020-07-20T07:52:36.744Z] func (w *Worker) CacheManager() cache.Manager {

[2020-07-20T07:52:36.744Z] ^

@thaJeztah
Copy link
Member

thaJeztah commented Jul 20, 2020

Are there noteworthy changes in this diff? If so, could you update the commit message to describe them?

@thaJeztah thaJeztah added the status/failing-ci Indicates that the PR in its current state fails the test suite label Jul 20, 2020
@thaJeztah thaJeztah added this to the 20.03.0 milestone Jul 20, 2020
@tonistiigi tonistiigi force-pushed the update-buildkit-0720 branch from ab86be9 to 870c52f Compare July 20, 2020 16:37
@tonistiigi tonistiigi force-pushed the update-buildkit-0720 branch from 870c52f to 8774804 Compare July 20, 2020 18:34
@thaJeztah thaJeztah removed the status/failing-ci Indicates that the PR in its current state fails the test suite label Jul 22, 2020
thaJeztah
thaJeztah approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpuguy83
cpuguy83 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 4203a1f into moby:master Jul 23, 2020
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Jul 28, 2020
@thaJeztah
vendor: update docker/docker 0f41a77c6993ade605a639fb25994cfe5e1b3fe8
097d573 
full diff: http://github.com/docker/docker/compare/78e6ffd279b627ebba046b9675ff4849091d9cc3...0f41a77c6993ade605a639fb25994cfe5e1b3fe8

Relevant changes:

- moby/moby#41234 vendor: update buildkit to 4d1f260e8
- various updates to swagger files
- moby/moby#41249 Replace swarm Capabilites API with cap add/drop API
    - updates swarmkit to 035d564a3686f5e348d861ec0c074ff26854c498
- moby/moby#41254 Deprecate KernelMemory

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah mentioned this pull request Jul 28, 2020
Merged
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Jul 29, 2020
@thaJeztah
vendor: update docker/docker 0f41a77c6993ade605a639fb25994cfe5e1b3fe8
3f6093f 
full diff: http://github.com/docker/docker/compare/78e6ffd279b627ebba046b9675ff4849091d9cc3...0f41a77c6993ade605a639fb25994cfe5e1b3fe8

Relevant changes:

- moby/moby#41234 vendor: update buildkit to 4d1f260e8
- various updates to swagger files
- moby/moby#41249 Replace swarm Capabilites API with cap add/drop API
    - updates swarmkit to 035d564a3686f5e348d861ec0c074ff26854c498
- moby/moby#41254 Deprecate KernelMemory

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Upstream-commit: 097d57314d12c5b2b8dd267353172e51948a25f1
Component: cli
akerouanton pushed a commit to akerouanton/cli that referenced this pull request Jul 29, 2020
@thaJeztah @akerouanton
vendor: update docker/docker 0f41a77c6993ade605a639fb25994cfe5e1b3fe8
c425e9e 
full diff: http://github.com/docker/docker/compare/78e6ffd279b627ebba046b9675ff4849091d9cc3...0f41a77c6993ade605a639fb25994cfe5e1b3fe8

Relevant changes:

- moby/moby#41234 vendor: update buildkit to 4d1f260e8
- various updates to swagger files
- moby/moby#41249 Replace swarm Capabilites API with cap add/drop API
    - updates swarmkit to 035d564a3686f5e348d861ec0c074ff26854c498
- moby/moby#41254 Deprecate KernelMemory

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@TBBle TBBle mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/builder Build docs/revisit impact/changelog status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

Image built from cached layers is missing data cache-from working unreliably

4 participants

@tonistiigi @AkihiroSuda @thaJeztah @cpuguy83