seccomp: allow 'rseq' syscall in default seccomp profile#41158
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jun 26, 2020
Merged
seccomp: allow 'rseq' syscall in default seccomp profile#41158thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Flowdalic
force-pushed
the
allow-rseq-seccomp
branch
from
8141fef to
ed8836d
Compare
thaJeztah
requested changes
Jun 26, 2020
Member
|
@justincormack PTAL |
Restartable Sequences (rseq) are a kernel-based mechanism for fast update operations on per-core data in user-space. Some libraries, like the newest version of Google's TCMalloc, depend on it [1]. This also makes dockers default seccomp profile on par with systemd's, which enabled 'rseq' in early 2019 [2]. 1: https://google.github.io/tcmalloc/design.html 2: systemd/systemd@6fee3be Signed-off-by: Florian Schmaus <[email protected]>
Flowdalic
force-pushed
the
allow-rseq-seccomp
branch
from
ed8836d to
d0d99b0
Compare
thaJeztah
approved these changes
Jun 26, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
(chatted with @justincormack, and he was ok with adding this)
justincormack
approved these changes
Jun 26, 2020
Member
|
@Flowdalic you'll likely want this in the containerd seccomp profile as well; https://github.com/containerd/containerd/tree/master/contrib/seccomp. Let me know if you want to open a PR there, or want me to open one |
Contributor
Author
|
@thaJeztah Thanks for pointing this out. I've created containerd/containerd#4347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restartable Sequences (rseq) are a kernel-based mechanism for fast
update operations on per-core data in user-space. Some libraries, like
the newest version of Google's TCMalloc, depend on it [1].
This also makes dockers default seccomp profile on par with systemd's,
which enabled 'rseq' in early 2019 [2].
1: https://google.github.io/tcmalloc/design.html
2: systemd/systemd@6fee3be