chrootarchive: fix "conversion from int to string yields a string of one rune"#41153
Merged
tiborvass merged 1 commit intomoby:masterfrom Jun 25, 2020
Merged
chrootarchive: fix "conversion from int to string yields a string of one rune"#41153tiborvass merged 1 commit intomoby:masterfrom
tiborvass merged 1 commit intomoby:masterfrom
Conversation
…one rune"
update test to fix go 1.15 linting failure:
pkg/chrootarchive/archive_test.go:103:32: conversion from int to string yields a string of one rune
relates to golang/go 32479
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
SamWhited
approved these changes
Jun 25, 2020
| excludes := make([]string, 65534) | ||
| for i := 0; i < 65534; i++ { | ||
| var i rune | ||
| for i = 0; i < 65534; i++ { |
Contributor
There was a problem hiding this comment.
nit: i is already 0. Alternatively, for i := rune(0); … might be a bit cleaner. But it doesn't really matter, LGTM either way.
Member
Author
There was a problem hiding this comment.
Ah, yes, could've done that 👍
Think I'll keep it as-if, as CI is a bit flaky (don't want to be running it multiple times to get green again 😞)
tiborvass
approved these changes
Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update test to fix go 1.15 linting failure:
relates to golang/go 32479