fix gotestsum.installer installing wrong version #41151
Conversation
|
Argh. Windows script also has the same problem Let me push another commit to fix that one (keeping it in a separate commit as 19.03 does not yet have that part, so easier to backport then) |
thaJeztah
force-pushed
the
fix_gotestsum_install_again
branch
4 times, most recently
from
1ddeaa3 to
610f1b2
Compare
|
CI is failing on a flaky test; #41138 |
|
All green now 👍 |
Dockerfile.windows
Outdated
There was a problem hiding this comment.
Doesn't this one need -ldflags to set main.version too?
There was a problem hiding this comment.
Ah, yes, perhaps we should add it there (we didn't do that before, it was mostly when I tried checking if it's the right version)
There was a problem hiding this comment.
or perhaps I should remove it from the other one, as we don't really use it 🤔
let me know if you feel strongly about one or the other
There was a problem hiding this comment.
I don't really feel strongly either way -- just that we should try to keep them consistent. 😅
I'm personally fine with this binary not knowing what version it is, but I don't run it very often, so I think I'm the wrong one to opine. 🤷 ❤️
There was a problem hiding this comment.
Agree, let's just be consistent.
When using go modules, `go build` will always fetch the latest version of the package, so ignores the version we previously `go get`'d. Instead of running `go get` and `go build` separately, this patch uses `go get` (without the `-d` option) to do it all in one step. Given that this binary is only used for testing, and only used inside the Dockerfile, we should consider inlining this step in the Dockerfile itself, but keeping that separate for now. Signed-off-by: Sebastiaan van Stijn <[email protected]>
When using go modules, `go build` will always fetch the latest version of the package, so ignores the version we previously `go get`'d. Instead of running `go get` and `go build` separately, this patch uses `go get` (without the `-d` option) to do it all in one step. Signed-off-by: Sebastiaan van Stijn <[email protected]>
No need for this binary as it's only used in tests. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
fix_gotestsum_install_again
branch
from
610f1b2 to
a9d22ca
Compare
4 participants
When using go modules,
go buildwill always fetch the latestversion of the package, so ignores the version we previously
go get'd.Instead of running
go getandgo buildseparately, this patch usesgo get(without the-doption) to do it all in one step.Given that this binary is only used for testing, and only used inside the
Dockerfile, we should consider inlining this step in the Dockerfile itself,
but keeping that separate for now.