info: add warnings about missing blkio cgroup support#41083
Merged
Conversation
These warnings were only logged, and could therefore be overlooked by users. This patch makes these more visible by returning them as warnings in the API response. We should probably consider adding "boolean" (?) fields for these as well, so that they can be consumed in other ways. In addition, some of these warnings could potentially be grouped to reduce the number of warnings that are printed. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Jun 8, 2020
Comment on lines
+134
to
+145
| if !sysInfo.BlkioReadBpsDevice { | ||
| v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.read_bps_device support") | ||
| } | ||
| if !sysInfo.BlkioWriteBpsDevice { | ||
| v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.write_bps_device support") | ||
| } | ||
| if !sysInfo.BlkioReadIOpsDevice { | ||
| v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.read_iops_device support") | ||
| } | ||
| if !sysInfo.BlkioWriteIOpsDevice { | ||
| v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.write_iops_device support") | ||
| } |
Member
Author
There was a problem hiding this comment.
We currently log these separately (and also this creates separate warnings for each), but I'm wondering if (in reality) its possible that (e.g.) throttle.read_bps_device is supported but throttle.write_bps_device is not supported (and vice-versa). Similar to iops ? Would it in practice be "all" or "none"?? If so, we could print a single warning instead of separate ones.
tonistiigi
approved these changes
Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These warnings were only logged, and could therefore be overlooked by users. This patch makes these more visible by returning them as warnings in the API response.
We should probably consider adding "boolean" (?) fields for these as well, so that they can be consumed in other ways. In addition, some of these warnings could potentially be grouped to reduce the number of warnings that are printed.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)