Skip to content

update runc binary to v1.0.0-rc91#41025

Merged
kolyshkin merged 1 commit into
moby:masterfrom
AkihiroSuda:runc-rc11-pre
Jul 2, 2020
Merged

update runc binary to v1.0.0-rc91#41025
kolyshkin merged 1 commit into
moby:masterfrom
AkihiroSuda:runc-rc11-pre

Conversation

@AkihiroSuda

@AkihiroSuda AkihiroSuda commented May 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

release note: https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc91

vendored library isn't updated in this commit (waiting for containerd to vendor runc rc91)

@AkihiroSuda

This comment has been minimized.

Sign in to view
@AkihiroSuda AkihiroSuda changed the title [DNM] trigger CI with runc rc11-pre [DNM] trigger CI with runc rc91-pre Jun 9, 2020
@AkihiroSuda

This comment has been minimized.

Sign in to view
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 9, 2020
Closed
@AkihiroSuda
AkihiroSuda force-pushed the runc-rc11-pre branch 3 times, most recently from 7b69c13 to 15dd75d Compare June 16, 2020 03:30
@AkihiroSuda AkihiroSuda changed the title [DNM] trigger CI with runc rc91-pre update runc binary to v1.0.0-rc91 Jul 2, 2020
@AkihiroSuda
AkihiroSuda marked this pull request as ready for review July 2, 2020 03:33
@AkihiroSuda
AkihiroSuda requested a review from tianon as a code owner July 2, 2020 03:33
@AkihiroSuda

AkihiroSuda commented Jul 2, 2020

Copy link
Copy Markdown
Member Author

Ready to review/merge

@thaJeztah @cpuguy83 @tianon PTAL

@thaJeztah

thaJeztah commented Jul 2, 2020

Copy link
Copy Markdown
Member

Do we want the vendoring updated as well (not for cherry-picking), or won't work yet until containerd is updated?

thaJeztah
thaJeztah approved these changes Jul 2, 2020
View reviewed changes

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda

AkihiroSuda commented Jul 2, 2020

Copy link
Copy Markdown
Member Author

Vendor update can be another PR

@AkihiroSuda
update runc binary to v1.0.0-rc91
91ca3e7 
release note: https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc91

vendored library isn't updated in this commit (waiting for containerd to vendor runc rc91)

Signed-off-by: Akihiro Suda <[email protected]>
@tianon

tianon commented Jul 2, 2020

Copy link
Copy Markdown
Member

Looks like there was a failure in the rootless tests -- do you think it's related or just a flake/fluke?

[2020-07-02T11:24:01.235Z] --- FAIL: TestDaemonIpcModePrivate (60.02s)
[2020-07-02T11:24:01.235Z] ipcmode_linux_test.go:233: [d357c9ba5dea7] failed to start daemon with arguments [-u unprivilegeduser -E XDG_RUNTIME_DIR=/go/src/github.com/docker/docker/bundles/test-integration/TestDaemonIpcModePrivate/d357c9ba5dea7/xdgrun -E HOME=/home/unprivilegeduser -E PATH=/go/src/github.com/docker/docker/bundles/test-integration/../dynbinary-daemon:/go/src/github.com/docker/docker/bundles/test-integration/../binary-daemon:/usr/local/cli:/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin -- dockerd-rootless.sh --data-root /go/src/github.com/docker/docker/bundles/test-integration/TestDaemonIpcModePrivate/d357c9ba5dea7/root --exec-root /tmp/dxr/d357c9ba5dea7 --pidfile /go/src/github.com/docker/docker/bundles/test-integration/TestDaemonIpcModePrivate/d357c9ba5dea7/docker.pid --userland-proxy=true --containerd-namespace d357c9ba5dea7 --containerd-plugins-namespace d357c9ba5dea7p --host unix:///tmp/docker-integration/d357c9ba5dea7.sock --debug --storage-driver overlay2 --default-ipc-mode private] : [d357c9ba5dea7] daemon exited and never started: context deadline exceeded

(Seems to me like it's just a fluke.)

Otherwise, this LGTM

@thaJeztah

thaJeztah commented Jul 2, 2020

Copy link
Copy Markdown
Member

kicked CI

kolyshkin
kolyshkin approved these changes Jul 2, 2020
View reviewed changes

@kolyshkin kolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
kolyshkin merged commit c833222 into moby:master Jul 2, 2020
@thaJeztah thaJeztah added this to the 20.03.0 milestone Jul 3, 2020
@thaJeztah thaJeztah mentioned this pull request Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes
@kolyshkin kolyshkin kolyshkin approved these changes
@tianon tianon Awaiting requested review from tianon

Assignees

No one assigned

Labels

area/runtime Runtime impact/changelog status/2-code-review

Projects

None yet

Milestone

20.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AkihiroSuda @thaJeztah @tianon @kolyshkin