pkg/sysinfo.applyPIDSCgroupInfo: optimize#41014
Merged
thaJeztah merged 2 commits intomoby:masterfrom May 25, 2020
Merged
Conversation
For some reason, commit 69cf037 chose not to use information already fetched, and called cgroups.FindCgroupMountpoint() instead. This is not a cheap call, as it has to parse the whole nine yards of /proc/self/mountinfo, and the info which it tries to get (whether the pids controller is present) is already available from cgMounts map. Signed-off-by: Kir Kolyshkin <[email protected]>
Some were misleading or vague, some were plain wrong. Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
Author
Contributor
Author
|
@thaJeztah PTAL |
AkihiroSuda
approved these changes
May 24, 2020
thaJeztah
added
kind/refactor
Member
|
@kolyshkin do you know how much time we save with this? Wondering if we should backport this (given that the fix itself is tiny and trivial), or not worth the effort? |
Contributor
Author
Up to 0.01s in busy scenarios, much less so on a relatively idle system. If it's a straightforward backport, I'd do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, commit 69cf037 (PR #18697) chose not to use information
already fetched, and called
cgroups.FindCgroupMountpoint()instead.This is not a cheap call, as it has to parse the whole nine yards
of /proc/self/mountinfo, and the info which it tries to get (whether
the pids controller is present) is already available from
cgMountsmap.