[19.03] Fix dns fallback regression#41009
Merged
thaJeztah merged 3 commits intoMay 28, 2020
Merged
Conversation
tiborvass
changed the title
cpuguy83
approved these changes
May 21, 2020
cpuguy83
left a comment
cpuguy83
left a comment
Member
There was a problem hiding this comment.
LGTM pending master PR merge.
tonistiigi
approved these changes
May 21, 2020
AkihiroSuda
approved these changes
May 21, 2020
tiborvass
force-pushed
the
19.03-fix-dns-fallback-regression
branch
from
May 21, 2020 20:13
ec32100 to
273943f
Compare
tiborvass
marked this pull request as draft
May 21, 2020 23:04
tiborvass
marked this pull request as ready for review
May 21, 2020 23:04
Member
|
Same comment here as on #41008 (comment)
|
tiborvass
marked this pull request as draft
May 26, 2020 16:38
Signed-off-by: Tibor Vass <[email protected]> (cherry picked from commit b280ea1) Signed-off-by: Tibor Vass <[email protected]>
tiborvass
force-pushed
the
19.03-fix-dns-fallback-regression
branch
3 times, most recently
from
May 28, 2020 10:16
8c8bb8d to
37bf1eb
Compare
thaJeztah
approved these changes
May 28, 2020
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
found one typo in a comment, but not a blocker
added 2 commits
May 28, 2020 10:52
Signed-off-by: Tibor Vass <[email protected]>
Signed-off-by: Tibor Vass <[email protected]> (cherry picked from commit e5ad8b14daf0a1ddb12c0b83d153531afffb908b) Signed-off-by: Tibor Vass <[email protected]>
tiborvass
force-pushed
the
19.03-fix-dns-fallback-regression
branch
from
May 28, 2020 10:52
37bf1eb to
c104a50
Compare
Member
|
(moving this out of draft) |
thaJeztah
marked this pull request as ready for review
May 28, 2020 11:02
Member
|
All green now; merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41003
fixes #41041
Ref moby/libnetwork#2551
Backport of #41008