Skip to content

update containerd binary to v1.4.0#40982

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
AkihiroSuda:containerd14beta0
Aug 21, 2020
Merged

update containerd binary to v1.4.0#40982
AkihiroSuda merged 1 commit intomoby:masterfrom
AkihiroSuda:containerd14beta0

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented May 17, 2020

@AkihiroSuda AkihiroSuda requested a review from tianon as a code owner May 17, 2020 10:28
@AkihiroSuda

This comment has been minimized.

@tianon
Copy link
Member

tianon commented May 19, 2020

Do you think we should leave this as a draft until 1.4.0 GA? (not sure we want master depending on a pre-release, especially while prepping for a release 😅)

@AkihiroSuda
Copy link
Member Author

If 20.0X GA is planned to be released after containerd 1.4 GA, we should merge this, otherwise we should not.
My understanding is the former one.
cc @cpuguy83 @thaJeztah

@AkihiroSuda
Copy link
Member Author

@cpuguy83 @thaJeztah PTAL

@thaJeztah
Copy link
Member

Discussing in the maintainers meeting, and we're leaning towards (at least initially) shipping 20.0x with containerd 1.3.x, with the option to later go to 1.4.x. Given that 1.3.x has had some time to mature (less risky)

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented May 28, 2020

@thaJeztah When is the ETA of 20.03?
Given that 19.03 required more than 3 months since beta1 to GA and we haven't reached 20.03 beta1 yet, I predict ETA of 20.03 GA to be around September or maybe October. containerd 1.4 is highly likely to be matured enough at that time.

Also, supporting cgroup2 (i.e. containerd 1.4) from the beginning of 20.03.0 would be good to shut up "Docker/Moby will never support cgroup2" hoax.

@AkihiroSuda AkihiroSuda changed the title update containerd binary to v1.4.0-beta.0 update containerd binary to v1.4.0-beta.1 May 30, 2020
@AkihiroSuda
Copy link
Member Author

@thaJeztah @tianon @cpuguy83

We are still not ready to release v20.0x soon: #40838
Any chance to get this PR reconsidered to be included for v20.0X?

@AkihiroSuda AkihiroSuda changed the title update containerd binary to v1.4.0-beta.1 update containerd binary to v1.4.0-beta.2 Jul 15, 2020
@AkihiroSuda
Copy link
Member Author

updated to beta2

@AkihiroSuda AkihiroSuda changed the title update containerd binary to v1.4.0-beta.2 update containerd binary to v1.4.0-rc.0 Aug 5, 2020
@AkihiroSuda
Copy link
Member Author

updated to rc.0

@AkihiroSuda AkihiroSuda changed the title update containerd binary to v1.4.0-rc.0 update containerd binary to v1.4.0-rc.1 Aug 12, 2020
@AkihiroSuda
Copy link
Member Author

updated to rc.1

@AkihiroSuda AkihiroSuda changed the title update containerd binary to v1.4.0-rc.1 update containerd binary to v1.4.0 Aug 17, 2020
@AkihiroSuda
Copy link
Member Author

Updated to v1.4.0 GA.

I still think Docker 20.XX should skip containerd 1.3 and use 1.4 from the beginning.

containerd 1.3 is likely to reach EOL (February 17, 2021) right after (or before, in the worst case) the release of Docker 20.XX .

@thaJeztah @cpuguy83 @tianon PTAL

@tao12345666333
Copy link
Contributor

Agree with @AkihiroSuda

I think as a newly released version, we should update its dependencies as much as possible in order to make it more active(or gitve it a longer maintenance period)

@cpuguy83
Copy link
Member

I agree.

The main concern is that docker-ce 19.03 will be required to update to containerd 1.4 (for new installs) unless people manually specify the containerd version when installing docker.
Having release specific channels for this would help.

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Discussing in the maintainers meeting with @cpuguy83 @tonistiigi, and we think we can start updating docker 19.03 to containerd 1.3, then start alphas/betas for docker 20.0x with containerd 1.4 on the test channels.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Member

Note that io.containerd.runtime.v1.linux has issues on 1.4.0, specifically with exec requests filling up log pipes from the shim which are never consumed, and thus eventually block the shim: containerd/containerd#4546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants