Fix flakey test for log file rotate.#40969
Merged
Merged
Conversation
cpuguy83
added
kind/bugfix
thaJeztah
reviewed
May 17, 2020
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
Left a suggestion / thought
Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
fix_flakey_log_rotate_test
branch
from
May 18, 2020 17:28
1fd8161 to
5ea5c02
Compare
thaJeztah
approved these changes
May 18, 2020
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM (if green) thanks for updating!
AkihiroSuda
approved these changes
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.