add dockerd-rootless-setuptool.sh#40950
Merged
Merged
Conversation
AkihiroSuda
force-pushed
the
dockerd-rootless-setuptool.sh
branch
2 times, most recently
from
May 11, 2020 14:49
b6cb760 to
ec4f5bc
Compare
AkihiroSuda
force-pushed
the
dockerd-rootless-setuptool.sh
branch
from
May 11, 2020 15:01
ec4f5bc to
0d2b0b5
Compare
Member
|
@tianon ptal 🤗 |
tianon
reviewed
May 14, 2020
tianon
left a comment
Member
There was a problem hiding this comment.
Overall not bad -- I noticed a few minor typos, but most of my suggestions are stylistic/reliability changes.
I realize this is kind of a lot of suggestions so if you'd rather have a PR against your branch to review, I'm happy to do that instead. 👍
AkihiroSuda
force-pushed
the
dockerd-rootless-setuptool.sh
branch
2 times, most recently
from
May 14, 2020 23:30
e1c5bba to
527968f
Compare
Member
Author
|
Thanks @tianon, addressed your comments |
Usage: `dockerd-rootless-setuptool.sh install --force` . See `--help` for further information. Co-authored-by: Tianon Gravi <[email protected]> Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
dockerd-rootless-setuptool.sh
branch
from
May 14, 2020 23:46
527968f to
c696b95
Compare
tianon
approved these changes
May 15, 2020
tianon
left a comment
Member
There was a problem hiding this comment.
Sorry noticed one more minor thing, but otherwise LGTM 👍 🎉
Member
Author
tonistiigi
approved these changes
May 21, 2020
AkihiroSuda
added a commit
to AkihiroSuda/docker-ce-packaging
that referenced
this pull request
May 21, 2020
dockerd-rootless-setuptool.sh was added to Moby in moby/moby#40950 Signed-off-by: Akihiro Suda <[email protected]>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 27, 2020
dockerd-rootless-setuptool.sh was added to Moby in moby/moby#40950 Signed-off-by: Akihiro Suda <[email protected]> Upstream-commit: 896c278 Component: packaging
HeroCC
pushed a commit
to HeroCC/docker-ce-packaging
that referenced
this pull request
Oct 6, 2021
dockerd-rootless-setuptool.sh was added to Moby in moby/moby#40950 Signed-off-by: Akihiro Suda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added
contrib/dockerd-rootless-setuptool.sh.The tool is expected to be used by https://get.docker.com/rootless script.
Can be included in RPM/DPKG packages as well.
Fix #40707
Relates to #40761
Replaces #40924 (Same as this PR but written in Go rather than in shell)
- How I did it
Rewrote https://get.docker.com/rootless .
The curl stuff is expected to be kept in https://get.docker.com/rootless .
Also, the storage driver is not detected in the new tool because the daemon should be able to choose overlay2/fuse-overlayfs/vfs automatically.
- How to verify it
Show usage:
Install (-> fail due to existing rootful Docker)
Install (ignore rootful Docker -> fail due to misconfiguration of subuid and subgid)
Install (try again after fixing up subuid and subgid -> success)
Uninstall:
- Description for the changelog
add dockerd-rootless-setuptool.sh
- A picture of a cute animal (not mandatory but encouraged)
🐧