API: swarm: move PidsLimit to TaskTemplate.Resources#40938
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jun 11, 2020
Merged
API: swarm: move PidsLimit to TaskTemplate.Resources#40938cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
3 tasks
thaJeztah
commented
May 10, 2020
Member
Author
There was a problem hiding this comment.
Should we name this Pids or PidsLimit ? Wasn't sure (and naming is hard)
The initial implementation followed the Swarm API, where PidsLimit is located in ContainerSpec. This is not the desired place for this property, so moving the field to TaskTemplate.Resources in our API. A similar change should be made in the SwarmKit API (likely keeping the old field for backward compatibility, because it was merged some releases back) Signed-off-by: Sebastiaan van Stijn <[email protected]>
tonistiigi
approved these changes
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #39882 (Add API support for PidsLimit on services), which implementation followed the Swarm API, where
PidsLimitis located inContainerSpec. This is not the desired place for this property, so moving the field toTaskTemplate.Resourcesin our API.After discussing in the maintainers meeting, we decided that we should update our API to move
PidsLimitto the right location before the 20.x release; a similar change should be made in the SwarmKit API (likely keeping the old field for backward compatibility, because it was merged some releases back (moby/swarmkit#2415))depends on
addresses the API side of #28618
- A picture of a cute animal (not mandatory but encouraged)