Add health start interval by cpuguy83 · Pull Request #40894 · moby/moby

cpuguy83 · 2020-05-02T21:56:08Z

This adds an additional interval to be used by healthchecks during the
start period.
Typically when a container is just starting you want to check if it is
ready more quickly than a typical healthcheck might run. Without this
users have to balance between running healthchecks to frequently vs
taking a very long time to mark a container as healthy for the first
time.

Replaces #33918
Closes #33410

cpuguy83 · 2020-05-02T21:59:07Z

A note about this:

Currently if a start interval is not specified, it will get the default start interval of 30s... which is the same as the normal interval.
This means, as currently coded, every healthcheck will have this start interval even for pre-existing containers.

cpuguy83 · 2020-05-02T22:18:24Z

I'll also note:

The only real interest I have in this PR is:

People have been asking for (something like) this
The other PR was the oldest open PR in the repo

One concern I have for this is the fact that healthcheck configs are in the container Config portion, which gets committed as part of the image config... which means changing this changes the image spec.... technically these healthceck configs aren't even in the OCI spec anyway, though.

bpascard · 2021-05-06T17:39:58Z

First I'd like to say @cpuguy83 rules.

Second are there are any updates on this PR? Any chance for this to be merged in its current form?

iraklisg · 2022-04-03T08:24:42Z

Is there any update about this PR? Thank you

thaJeztah · 2022-04-07T18:54:07Z

@dperny can you check if this requires changes on the SwarmKit side to allow this to be used?

aaccioly · 2022-05-31T21:05:48Z

Hey. Is this PR full being considered?

tianon

Seems OK to me ❤️

I'd love to have @corhere take a look if you've got some time?
(I seem to recall you've looked at the health checks implementation recently? 👀 😇)

tianon · 2022-06-01T23:29:39Z

(Needs a rebase, but it appears to be pretty superficial -- just markdown and yaml, so implementation probably doesn't need to change for that 👀)

thaJeztah · 2022-06-02T20:34:28Z

I did a quick rebase, and added a second commit with some changes I wanted to suggest; @cpuguy83 PTAL if that last commit looks sane to your (if so I can squash)

corhere

The logic for selecting between startInterval and probeInterval is inconsistent with the behavior described by the Swagger docs and with how handleProbeResult decides when to start incrementing the failure streak. Which is the intended behavior?

daemon/health.go

This is useless as this is not an initial delay. We need this [PR](moby/moby#40894), which may land soon...

bpascard · 2022-11-15T19:12:57Z

Can we expect this PR to land in 22.06 ?

cpuguy83 · 2022-11-15T20:03:39Z

@bpascard Nope.

bpascard · 2022-12-06T19:28:11Z

Any chances this PR lands in 23.0 ?

corhere · 2022-12-06T22:33:42Z

@bpascard Nope. 23.0 is the new name for the release formerly known as 22.06.

neersighted · 2023-02-08T20:08:52Z

@cpuguy83 will you have time to rebase and address reviews on this one soon?

cpuguy83 · 2023-07-05T23:38:51Z

😭 Windows

'count' is not recognized as an internal or external command

I don't blame Windows too much here, though, since its some custom busybox on Windows.

This adds an additional interval to be used by healthchecks during the start period. Typically when a container is just starting you want to check if it is ready more quickly than a typical healthcheck might run. Without this users have to balance between running healthchecks to frequently vs taking a very long time to mark a container as healthy for the first time. Signed-off-by: Brian Goff <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>

cpuguy83 · 2023-07-06T00:04:04Z

Updated this to skip the new test on Windows.

cpuguy83 · 2023-07-06T00:34:00Z

All green now.

cpuguy83 · 2023-07-06T19:39:05Z

Swarmkit PR: moby/swarmkit#3142
CLI PR: docker/cli#4405
Compose Spec: compose-spec/compose-spec#383
Dockerfile: moby/buildkit#3998

cpuguy83 · 2023-07-06T22:39:00Z

Created a tracking issue for all the other changes that need to be completed before the 25.0 release: #45897

cpuguy83 requested review from AkihiroSuda, thaJeztah and tianon May 2, 2020 21:56

cpuguy83 mentioned this pull request May 2, 2020

Perform first healthcheck on startup without waiting the specified interval #33918

Closed

cpuguy83 added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/1-design-review labels May 2, 2020

domgenv mentioned this pull request Mar 18, 2022

Perform first healthcheck on startup without waiting the specified interval #33410

Closed

thaJeztah added this to the 22.04.0 milestone Apr 7, 2022

tianon approved these changes Jun 1, 2022

View reviewed changes

thaJeztah force-pushed the health_start_interval branch from 9816d6c to a71a096 Compare June 2, 2022 20:33

corhere requested changes Jun 2, 2022

View reviewed changes

daemon/health.go Outdated Show resolved Hide resolved

daemon/health.go Outdated Show resolved Hide resolved

corhere mentioned this pull request Jul 25, 2022

Adds a simple healthcheck every 2s amir20/dozzle#1814

Merged

vincentbernat added a commit to akvorado/akvorado that referenced this pull request Jul 30, 2022

docker: do not increase start period

4ac1d3b

This is useless as this is not an initial delay. We need this [PR](moby/moby#40894), which may land soon...

thaJeztah modified the milestones: 22.06.0, v-next Aug 18, 2022

daniharo added a commit to daniharo/mordente that referenced this pull request Oct 24, 2022

Remove healthcheck to solve CPU issue (until moby/moby#40894 is merged)

be3f44c

thaJeztah mentioned this pull request Apr 12, 2023

health check with higher rate during start_period docker/compose#10461

Closed

cpuguy83 force-pushed the health_start_interval branch from d7fba45 to 2216d3c Compare July 5, 2023 23:44

neersighted merged commit e4c866f into moby:master Jul 6, 2023

cpuguy83 deleted the health_start_interval branch July 6, 2023 18:44

This was referenced Jul 6, 2023

Add support for health start interval docker/cli#4405

Merged

Add support for health start interval moby/swarmkit#3142

Merged

This was referenced Jul 6, 2023

Add start_interval to healthcheck compose-spec/compose-spec#383

Merged

Add support for health start interval moby/buildkit#3998

Merged

thaJeztah added impact/api impact/changelog labels Jul 6, 2023

cpuguy83 mentioned this pull request Jul 6, 2023

Tracking issue for health start interval #45897

Open

12 tasks

bpascard mentioned this pull request Jul 10, 2023

Implement healthcheck start interval docker/docker-py#3157

Open

glours mentioned this pull request Aug 6, 2023

start-interval parameter for docker compose healthcheck docker/compose#10830

Closed

graham2071 mentioned this pull request Aug 9, 2023

dockerfile parse error unknown flag: start-interval docker/cli#4486

Closed

vvoland mentioned this pull request Aug 31, 2023

image/spec: Add Healthcheck.StartInterval (v1.3) #46381

Merged

MarcHagen mentioned this pull request Sep 20, 2023

invalid flag: --start-interval hadolint/hadolint#978

Open

3 tasks

thaJeztah mentioned this pull request Oct 14, 2023

HealthCheck: add validation for minimum accepted start-interval (1ms) #46646

Merged

akerouanton mentioned this pull request Oct 25, 2023

api: fix a nil check on the wrong var #46716

Merged

corhere mentioned this pull request Oct 30, 2023

30s HealthStartInterval being applied to containers created with API 1.43 client #46733

Closed

thaJeztah mentioned this pull request Nov 3, 2023

Fix case where health start interval is 0 uses default #46764

Merged

jjbustamante mentioned this pull request Feb 5, 2024

bump github.com/moby/buildkit from 0.11.6 to 0.12.4 (requires some manual massaging it seems) GoogleContainerTools/kaniko#2954

Closed

Khushiyant mentioned this pull request Feb 8, 2024

feat: implement healthcheck start_interval docker/docker-py#3226

Open

xarem mentioned this pull request Mar 14, 2024

Healthcheck: StartInterval whatwedo/docker-base-images#63

Open

thaJeztah mentioned this pull request Nov 14, 2024

Run initial healthcheck earlier than interval #48874

Open

ollypom mentioned this pull request Nov 18, 2024

[ECS] [request]: Add startInterval to Container Health Check aws/containers-roadmap#2473

Open

Comments

Conversation

cpuguy83 commented May 2, 2020 • edited by neersighted Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cpuguy83 commented May 2, 2020

Uh oh!

cpuguy83 commented May 2, 2020

Uh oh!

bpascard commented May 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iraklisg commented Apr 3, 2022

Uh oh!

thaJeztah commented Apr 7, 2022

Uh oh!

aaccioly commented May 31, 2022

Uh oh!

tianon left a comment

Choose a reason for hiding this comment

Uh oh!

tianon commented Jun 1, 2022

Uh oh!

thaJeztah commented Jun 2, 2022

Uh oh!

corhere left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bpascard commented Nov 15, 2022

Uh oh!

cpuguy83 commented Nov 15, 2022

Uh oh!

bpascard commented Dec 6, 2022

Uh oh!

corhere commented Dec 6, 2022

Uh oh!

neersighted commented Feb 8, 2023

Uh oh!

cpuguy83 commented Jul 5, 2023

Uh oh!

cpuguy83 commented Jul 6, 2023

Uh oh!

cpuguy83 commented Jul 6, 2023

Uh oh!

cpuguy83 commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cpuguy83 commented Jul 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cpuguy83 commented May 2, 2020 •

edited by neersighted

Loading

bpascard commented May 6, 2021 •

edited

Loading

cpuguy83 commented Jul 6, 2023 •

edited

Loading