Dockerfile.buildx: bump to Go 1.13.10#40893
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 6, 2020
Merged
Conversation
Looks like this Dockerfile was not yet updated; possibly because `go mod` issues when building buildx 0.3.1. Given that the upstream repository uses vendoring, I: - removed the `go mod download` step - added `-mod=vendor` to use vendoring mode Signed-off-by: Sebastiaan van Stijn <[email protected]>
AkihiroSuda
approved these changes
May 4, 2020
Member
Author
|
@AkihiroSuda @tonistiigi was just thinking; would it make sense to have (multi-arch?) images for buildx pushed to docker hub? |
Member
Author
|
@cpuguy83 ptal |
Member
Author
|
bringing this one in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this Dockerfile was not yet updated; possibly because
go modissues when building buildx 0.3.1.Given that the upstream repository uses vendoring, I:
go mod downloadstep-mod=vendorto use vendoring mode