Make binary: install all containerd shims to bundles#40882
Merged
tiborvass merged 1 commit intomoby:masterfrom May 5, 2020
Merged
Make binary: install all containerd shims to bundles#40882tiborvass merged 1 commit intomoby:masterfrom
tiborvass merged 1 commit intomoby:masterfrom
Conversation
Member
Author
|
ping @AkihiroSuda @cpuguy83 PTAL |
AkihiroSuda
reviewed
May 1, 2020
thaJeztah
force-pushed
the
containerd_all_binaries
branch
from
d776cd1 to
4211a28
Compare
Member
Author
|
@AkihiroSuda @tiborvass updated PTAL |
AkihiroSuda
approved these changes
May 1, 2020
tiborvass
reviewed
May 1, 2020
tiborvass
reviewed
May 1, 2020
Contributor
There was a problem hiding this comment.
why here? this is supposed to be at top of files
Member
Author
There was a problem hiding this comment.
I did the () braces to run it in a sub-shell, so that the set -e wouldn't affect other scripts running in the same session. Not sure if that makes sense 😅
The containerd.installer was updated to also copy `containerd-shim-runc-v2`, but `hack/make/binary-daemon` did not copy it to the bundles directory. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
containerd_all_binaries
branch
from
4211a28 to
f85bea4
Compare
Member
Author
|
@tiborvass I removed the changes to containerd.installer from this PR (moved to #40892); PTAL |
tiborvass
approved these changes
May 5, 2020
Member
Author
|
@tiborvass good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The containerd.installer was updated to also copy
containerd-shim-runc-v2(in #40658), buthack/make/binary-daemondid not copy it to the bundles directory.