[19.03] vendor: swarmkit 0b8364e7d08aa0e972241eb59ae981a67a587a0e#40831
Merged
Conversation
full diff: moby/swarmkit@062b694...0b8364e - Fix leaking tasks.db Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
@cpuguy83 @SamWhited @dperny PTAL |
SamWhited
approved these changes
Apr 16, 2020
SamWhited
left a comment
SamWhited
left a comment
Contributor
There was a problem hiding this comment.
Ran vndr and nothing changes and the commit appears right so LGTM.
AkihiroSuda
approved these changes
Apr 17, 2020
Closed
|
For the uninitiated, what is LGTM short for? |
Member
Author
|
"look good to me" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: moby/swarmkit@062b694...0b8364e