Hmm.. ppc64le nodes are failing again with networking issues;

[2020-04-16T18:52:43.065Z] fatal: unable to access 'https://github.com/docker/buildx.git/': Could not resolve host: github.com
[2020-04-16T18:52:43.065Z] The command '/bin/sh -c git clone "${BUILDX_REPO}" /buildx' returned a non-zero code: 128
[2020-04-16T18:52:43.065Z] Makefile:279: recipe for target 'bundles/buildx' failed
[2020-04-16T18:52:43.065Z] make: *** [bundles/buildx] Error 128

This was on this node: https://ci-next.docker.com/public/computer/ppc64le-ubuntu-19/systemInfo - looks like all previous failures were on that node as well; let me disable it to see if it is just that one.

Ah; I see some workers ran out of swap space; are we missing some cleanup step in CI? https://ci-next.docker.com/public/computer/

I would put "pkg/term: vendor moby/term and make pkg/term an alias" commit first and test with it (to make sure the deprecated stuff works) and only after it add the "remove uses of deprecated pkg/term" commit.

Since Github web UI does not show the patches in the order they are applied, please ignore this if commits are already in the order described above.

Also it looks like the package-wide deprecation notice is missing.

I would put "pkg/term: vendor moby/term and make pkg/term an alias" commit first and test with it (to make sure the deprecated stuff works) and only after it add the "remove uses of deprecated pkg/term" commit.

I swapped the last two commits

Also it looks like the package-wide deprecation notice is missing.

Does golang support deprecating the package as a whole, or only individual functions? 🤔 Wondering if it adds anything if all functions are already marked "deprecated"

I swapped the last two commits

Thanks! It also need to test it with the commit that starts using the deprecated package (it should at least build, this is a sure way to know the package is working and nothing is amiss).

Does golang support deprecating the package as a whole, or only individual functions?

Yes ("or even a whole package"):
https://github.com/golang/go/wiki/Deprecated

Wondering if it adds anything if all functions are already marked "deprecated"

I think it does:

1. Package-level documentation would start with the notice this is deprecated.
2. A mere import of the package would be considered a linter issue.
3. Maybe it's easier to deprecate the whole package at once.

@kolyshkin updated; added deprecation message for the package