swarm: fix API version detection#40816
Merged
tiborvass merged 1 commit intomoby:masterfrom Apr 15, 2020
Merged
Conversation
While the docker cli may be sending a "version" header, this header is not part of the API, or at least should not determin what API version is used. This code was added in c0afd9c, to adjust the handling of requests when an older version of the API was used, but because the code relied on the "version" header set by the CLI, it didn't work with other clients (e.g. when using cURL to make an API request). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/api
Member
Author
tiborvass
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while testing some variations of API versions in #39882, but using cURL instead of the docker cli or docker client.
While the docker cli may be sending a "version" header, this header is not part of the API, or at least should not determin what API version is used.
This code was added in c0afd9c (#32388), to adjust the handling of requests when an older version of the API was used, but because the code relied on the "version" header set by the CLI, it didn't work with other clients (e.g. when using cURL to make an API request).
- Description for the changelog