[19.03] vendor: containerd 481103c8793316c118d9f795cde18060847c370e#40758
Merged
Conversation
thaJeztah
added
area/distribution
Member
Author
|
These changes should bring in fixes w.r.t. matching the correct arm image. Note that this is not a cherry-pick from master, but just bumping the containerd version to the merge commit with the fix (containerd/containerd#3270) |
Member
Author
full diff: containerd/containerd@7c1e883...481103c - Fix error handling for task deletion - Fix fd leak of shim log - Fix killall when use pidnamespace - Improve ARM platform matching Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
19.03_backport_arm_matching
branch
from
March 30, 2020 17:36
22a88aa to
359edd8
Compare
StefanScherer
approved these changes
Mar 30, 2020
StefanScherer
left a comment
StefanScherer
left a comment
Contributor
There was a problem hiding this comment.
LGTM,
internal tests show that a DOCKER_BUILDKIT=1 docker build now work with multi-arch images used in FROM.
tiborvass
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: containerd/containerd@7c1e883...481103c
- Description for the changelog
- Improve ARM platform matching