seccomp: add 64-bit time_t syscalls#40739
Merged
kolyshkin merged 1 commit intomoby:masterfrom Apr 2, 2020
Merged
Conversation
Relates to https://patchwork.kernel.org/patch/10756415/ Added to whitelist: - `clock_getres_time64` (equivalent of `clock_getres`, which was whitelisted) - `clock_gettime64` (equivalent of `clock_gettime`, which was whitelisted) - `clock_nanosleep_time64` (equivalent of `clock_nanosleep`, which was whitelisted) - `futex_time64` (equivalent of `futex`, which was whitelisted) - `io_pgetevents_time64` (equivalent of `io_pgetevents`, which was whitelisted) - `mq_timedreceive_time64` (equivalent of `mq_timedreceive`, which was whitelisted) - `mq_timedsend_time64 ` (equivalent of `mq_timedsend`, which was whitelisted) - `ppoll_time64` (equivalent of `ppoll`, which was whitelisted) - `pselect6_time64` (equivalent of `pselect6`, which was whitelisted) - `recvmmsg_time64` (equivalent of `recvmmsg`, which was whitelisted) - `rt_sigtimedwait_time64` (equivalent of `rt_sigtimedwait`, which was whitelisted) - `sched_rr_get_interval_time64` (equivalent of `sched_rr_get_interval`, which was whitelisted) - `semtimedop_time64` (equivalent of `semtimedop`, which was whitelisted) - `timer_gettime64` (equivalent of `timer_gettime`, which was whitelisted) - `timer_settime64` (equivalent of `timer_settime`, which was whitelisted) - `timerfd_gettime64` (equivalent of `timerfd_gettime`, which was whitelisted) - `timerfd_settime64` (equivalent of `timerfd_settime`, which was whitelisted) - `utimensat_time64` (equivalent of `utimensat`, which was whitelisted) Not added to whitelist: - `clock_adjtime64` (equivalent of `clock_adjtime`, which was not whitelisted) - `clock_settime64` (equivalent of `clock_settime`, which was not whitelisted) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
ping @justincormack @cpuguy83 @AkihiroSuda PTAL |
This was referenced Mar 25, 2020
Contributor
These two are obsoleted in favor of |
kolyshkin
reviewed
Apr 2, 2020
kolyshkin
reviewed
Apr 2, 2020
| "mq_notify", | ||
| "mq_open", | ||
| "mq_timedreceive", | ||
| "mq_timedreceive_time64", |
kolyshkin
requested changes
Apr 2, 2020
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
fix the name for mq_timedreceiv_time64, otherwise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(hopefully) fixes / addresses: #40734
Relates to https://patchwork.kernel.org/patch/10756415/
Added to whitelist:
clock_getres_time64(equivalent ofclock_getres, which was whitelisted)clock_gettime64(equivalent ofclock_gettime, which was whitelisted)clock_nanosleep_time64(equivalent ofclock_nanosleep, which was whitelisted)futex_time64(equivalent offutex, which was whitelisted)io_pgetevents_time64(equivalent ofio_pgetevents, which was whitelisted)mq_timedreceive_time64(equivalent ofmq_timedreceive, which was whitelisted)mq_timedsend_time64(equivalent ofmq_timedsend, which was whitelisted)ppoll_time64(equivalent ofppoll, which was whitelisted)ppollwas removed in libseccomp; was it confused forpoll?pselect6_time64(equivalent ofpselect6, which was whitelisted)recvmmsg_time64(equivalent ofrecvmmsg, which was whitelisted)_time64equivalent forrecvmsg?rt_sigtimedwait_time64(equivalent ofrt_sigtimedwait, which was whitelisted)sched_rr_get_interval_time64(equivalent ofsched_rr_get_interval, which was whitelisted)semtimedop_time64(equivalent ofsemtimedop, which was whitelisted)timer_gettime64(equivalent oftimer_gettime, which was whitelisted)timer_settime64(equivalent oftimer_settime, which was whitelisted)timerfd_gettime64(equivalent oftimerfd_gettime, which was whitelisted)timerfd_settime64(equivalent oftimerfd_settime, which was whitelisted)utimensat_time64(equivalent ofutimensat, which was whitelisted)_time64equivalent forutimeandutimes?Not added to whitelist:
clock_adjtime64(equivalent ofclock_adjtime, which was not whitelisted)clock_settime64(equivalent ofclock_settime, which was not whitelisted)To be looked at:
These syscalls are also new (and added to libseccomp in seccomp/libseccomp@bf747eb), but need to be looked at separately
clone3(equivalent ofclone? which was not whitelisted)fsconfigfsmountfsopenfspickmove_mountopen_treepidfd_openpidfd_send_signal- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)