test-integration: support more rootless tests#40689
Merged
thaJeztah merged 2 commits intomoby:masterfrom Mar 30, 2020
Merged
Conversation
6 tasks
AkihiroSuda
force-pushed
the
test-rootless2
branch
from
01b9f4a to
1787cab
Compare
See rootless-containers/rootlesskit#127 RootlessKit changes: rootless-containers/rootlesskit@v0.9.1...v0.9.2 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
test-rootless2
branch
from
1787cab to
6420b69
Compare
AkihiroSuda
force-pushed
the
test-rootless2
branch
3 times, most recently
from
f05e7b2 to
0af7d6c
Compare
AkihiroSuda
force-pushed
the
test-rootless2
branch
5 times, most recently
from
eb379c7 to
27b2e81
Compare
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
test-rootless2
branch
from
27b2e81 to
5e1b246
Compare
AkihiroSuda
changed the title
Member
Author
|
@thaJeztah @cpuguy83 PTAL? |
Member
Author
|
@thaJeztah PTAL? |
thaJeztah
approved these changes
Mar 30, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
sorry, thought I LGTM'd already 😓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
support more rootless tests
- How I did it
Removed
t.Skip("github.com/docker/docker/testutil/daemon.Daemon doesn't support DOCKER_ROOTLESS").Also bumped up RootlessKit: rootless-containers/rootlesskit@v0.9.1...v0.9.2
Contains support for forwarding signals from RootlessKit to dockerd (rootless-containers/rootlesskit#127)
- How to verify it
DOCKER_EXPERIMENTAL=1 DOCKER_ROOTLESS=1 TEST_SKIP_INTEGRATION_CLI=1 make test-integration- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
🐧