Skip to content

pkg/symlink: don't depend on pkg/system and pkg/longpath#40648

Merged
cpuguy83 merged 1 commit intomoby:masterfrom
thaJeztah:standalone_symlink
Mar 10, 2020
Merged

pkg/symlink: don't depend on pkg/system and pkg/longpath#40648
cpuguy83 merged 1 commit intomoby:masterfrom
thaJeztah:standalone_symlink

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Mar 9, 2020
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Mar 9, 2020

Actually, let me include the changes of #40645 in this package as well looks like this package was already updated with those

@thaJeztah
Copy link
Copy Markdown
Member Author

@cpuguy83 @AkihiroSuda ptal

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 4634ce6 into moby:master Mar 10, 2020
@thaJeztah thaJeztah deleted the standalone_symlink branch March 10, 2020 16:42
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants