pkg/system: replace more uses of "syscall"#40645
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Mar 9, 2020
Merged
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
thaJeztah
force-pushed
the
replace_more_syscall
branch
2 times, most recently
from
6836a16 to
e7ee18e
Compare
lowenna
approved these changes
Mar 9, 2020
Member
lowenna
left a comment
lowenna
left a comment
There was a problem hiding this comment.
LGTM with confirmation of that query
Member
There was a problem hiding this comment.
Pretty sure this is OK, but can you confirm no higher level caller in the codebase takes a dependency on a specific error. Also applies in OpenFileSequential
Member
Author
There was a problem hiding this comment.
Hm, good point; given that we documented MkdirAll above as a "drop in" replacement for os.MkdirAll, perhaps it's too risky. I couldn't find an issue at a glance, but given that it's only a small enhancement, let's revert these
follow-up to 069fdc8, replacing more uses of the syscall package in favor of their "windows" equivalents in golang.org/x/sys. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
replace_more_syscall
branch
from
e7ee18e to
079fb80
Compare
This was referenced Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to 069fdc8 (#33399), replacing more uses of the syscall package in favor of their "unix", "windows" equivalents in golang.org/x/sys.