Update DNS library#40579
Merged
thaJeztah merged 1 commit intomoby:masterfrom Feb 27, 2020
SamWhited:dns_update
Merged
Conversation
This makes sure that we don't become vulnerable to CVE-2018-17419 or CVE-2019-19794 in the future. Signed-off-by: Sam Whited <[email protected]>
AkihiroSuda
approved these changes
Feb 26, 2020
This was referenced Feb 28, 2020
|
Thank you very much! Support for Why hasn't it been documented yet? |
Member
|
@albert-a quite likely overlooked because it's in a separate repository. Could you open a ticket in https://github.com/docker/docs ? /cc @dvdksn @akerouanton |
1 task
|
@thaJeztah Sure! I opened the ticket. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #40534
closes #40534
This makes sure that we don't become vulnerable to CVE-2018-17419 or
CVE-2019-19794 in the future. As far as I can tell we are not vulnerable to either right now, but if someone were to use one of the affected methods in the future we could become vulnerable with our current dependency.
- What I did
Bumped the version of
github.com/miekg/dnsto v1.1.27 invendor.conf.- How I did it
Manually edited the file, then ran the version of vendor installed in our containers by default to update the vendor tree.
eg.
go get -u github.com/LK4D4/vndr@85886e1ac99b8d96590e6e0d9f075dc7a711d132- How to verify it
CI should do that, I'm waiting on that now.
This also updates libnetwork to 264bffcb88c1b6b7471c04e3c6b3f301233a544b;
full diff: moby/libnetwork@feeff4f...264bffc
includes:
com.docker.network.bridge.inhibit_ipv4label/configuration- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)