Skip to content

vendor: bump libnetwork 6659f7f4d8c1ec7a412a33f8973423ad38d22982#40534

Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:bump_libnetwork
Closed

vendor: bump libnetwork 6659f7f4d8c1ec7a412a33f8973423ad38d22982#40534
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:bump_libnetwork

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 17, 2020

full diff: moby/libnetwork@feeff4f...6659f7f

includes:

- Description for the changelog

- Add support for a `com.docker.network.bridge.inhibit_ipv4` driver label to skip IPv4 configuration of bridge interface docker/libnetwork#2317
- Add support for a ` com.docker.network.host_ipv4` driver label to choose outbound (external) IP for containers docker/libnetwork#2454
- Improve load balancer performance for ingress network with lots of parallel requests docker/libnetwork#2491

- A picture of a cute animal (not mandatory but encouraged)

full diff: moby/libnetwork@feeff4f...6659f7f

includes:

- moby/libnetwork#2317 Allow bridge net driver to skip IPv4 configuration of bridge interface
    - adds support for a `com.docker.network.bridge.inhibit_ipv4` label/configuration
    - addresses moby#37430 Prevent bridge network driver from setting IPv4 address on bridge interface
- moby/libnetwork#2454 Support for com.docker.network.host_ipv4 driver label
    - addresses moby#30053 Unable to choose outbound (external) IP for containers
- moby/libnetwork#2491 Improving load balancer performance
    - addresses moby#35082 [SWARM] Very poor performance for ingress network with lots of parallel requests

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

@arkodg could you have a look at;

  • wether or not Improving load balancer performance libnetwork#2491 should be backported to the 19.03 branch
  • updating the documentation to include the new com.docker.network.bridge.inhibit_ipv4 and com.docker.network.host_ipv4 options
  • check if any of the issues I marked as "addresses" should be changed to "fixes"

golang.org/x/sync 1d60e4601c6fd243af51cc01ddf169918a5407ca
github.com/pkg/errors ba968bfe8b2f7e042a574c888954fccecfa385b4 # v0.8.1
github.com/ishidawataru/sctp 6e2cb1366111dcf547c13531e3a263a067715847
go.opencensus.io 9c377598961b706d1542bd2d84d538b5094d596e # v0.22.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is being updated in #39838

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @thaJeztah !

@arkodg
Copy link
Contributor

arkodg commented Feb 18, 2020

don't think we should back port any to 19.03
created a issue docker/docs#10298, will need to get updated/go-live once we are closer to a 20.03 release

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

@arkodg can you check if the "addresses" should be "fixes" for all of the ones listed? I wasn't sure if they would all be fully fixed by these patches

@arkodg
Copy link
Contributor

arkodg commented Feb 24, 2020

@thaJeztah the fixes should address the issues you have linked

@thaJeztah
Copy link
Member Author

Thx! Changed "addresses" to "fixes"

@thaJeztah
Copy link
Member Author

@AkihiroSuda @tonistiigi PTAL

@thaJeztah thaJeztah added this to the 20.03.0 milestone Feb 25, 2020
@SamWhited SamWhited mentioned this pull request Feb 28, 2020
@thaJeztah
Copy link
Member Author

superseded by #40579

@thaJeztah thaJeztah closed this Feb 28, 2020
@thaJeztah thaJeztah deleted the bump_libnetwork branch February 28, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants