Skip to content

[19.03] Update Golang 1.12.17#40533

Merged
cpuguy83 merged 1 commit into
moby:19.03from
thaJeztah:19.03_update_golang_1.12.17
Feb 20, 2020
Merged

[19.03] Update Golang 1.12.17#40533
cpuguy83 merged 1 commit into
moby:19.03from
thaJeztah:19.03_update_golang_1.12.17

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

full diff: golang/go@go1.12.16...go1.12.17

go1.12.17 (released 2020/02/12) includes a fix to the runtime. See the Go 1.12.17
milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.12.17+label%3ACherryPickApproved

- Description for the changelog

full diff: golang/go@go1.12.16...go1.12.17

go1.12.17 (released 2020/02/12) includes a fix to the runtime. See the Go 1.12.17
milestone on the issue tracker for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.12.17+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@AkihiroSuda

Copy link
Copy Markdown
Member

LGTM, but can we upgrade to 1.13? 1.12 will reach EOL soon.

@thaJeztah

Copy link
Copy Markdown
Member Author

Yes, we should probably update to 1.13 in an upcoming patch release (I can prepare PR's for that).

Given that we'll likely have to do a new (19.03.7) release soon (to included an updated containerd version to address the regression in containerd 1.2.12; containerd/containerd#4033), I'd like to reduce the number of changes for 19.03.7 if possible.

@silvin-lubecki silvin-lubecki left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
cpuguy83 merged commit e145add into moby:19.03 Feb 20, 2020
@thaJeztah
thaJeztah deleted the 19.03_update_golang_1.12.17 branch February 20, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants