Update windows container utility to fix compilation on gcc-mingw-w64 8.3 #40526
Merged
cpuguy83 merged 2 commits intomoby:masterfrom Feb 21, 2020
Merged
Update windows container utility to fix compilation on gcc-mingw-w64 8.3 #40526cpuguy83 merged 2 commits intomoby:masterfrom
cpuguy83 merged 2 commits intomoby:masterfrom
Conversation
Member
thaJeztah
commented
Feb 14, 2020
thaJeztah
commented
- bump windows-container-utility aa1ba87e99b68e0113bd27ec26c60b88f9d4ccd9
- full diff: docker-archive/windows-container-utility@e004a14...aa1ba87
- Use standard include paths instead of hard-coding
- revert 25a1bf5 "Fix containerutility compilation on gcc-mingw-w64 8.3" (part of Dockerfile: switch golang image to "buster" variant #39880)
full diff: docker-archive/windows-container-utility@e004a14...aa1ba87 changes: - Use standard include paths instead of hard-coding Signed-off-by: Sebastiaan van Stijn <[email protected]>
This reverts commit 25a1bf5. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
yeah, we couldn't come up with a reason why the paths were hard-coded, and so far haven't seen issues with the temporary fix, so I YOLO merged the fix in the utility Makefile to use the standard paths |
Member
Author
|
@AkihiroSuda @cpuguy83 ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.