Skip to content

fix goimports#40501

Merged
thaJeztah merged 1 commit intomoby:masterfrom
AkihiroSuda:fix-goimports
Feb 11, 2020
Merged

fix goimports#40501
thaJeztah merged 1 commit intomoby:masterfrom
AkihiroSuda:fix-goimports

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Feb 11, 2020

Found in #40493 (comment)
Introduced in #40472
Not sure why CI didn't catch these errors.

Signed-off-by: Akihiro Suda <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

CI is hanging on docker-py (addressing the failure in #40500)

"validate" step passed;

[2020-02-11T13:24:26.474Z] + docker run --rm -t --privileged -v /home/ubuntu/workspace/moby_PR-40501/bundles:/go/src/github.com/docker/docker/bundles -v /home/ubuntu/workspace/moby_PR-40501/.git:/go/src/github.com/docker/docker/.git --name docker-pr1 -e DOCKER_EXPERIMENTAL -e DOCKER_GITCOMMIT=7270d7eb94f8cc47b99210481d53f4011cf7a5ce -e DOCKER_GRAPHDRIVER -e TEST_FORCE_VALIDATE -e VALIDATE_REPO=https://github.com/moby/moby.git -e VALIDATE_BRANCH=master docker:7270d7eb94f8cc47b99210481d53f4011cf7a5ce hack/validate/default
[2020-02-11T13:24:28.356Z] Congratulations!  All commits are properly signed with the DCO!
[2020-02-11T13:24:28.356Z] Congratulations!  Packages in "./pkg/..." are safely isolated from internal code.
[2020-02-11T13:24:28.356Z] No api/types/ or api/swagger.yaml changes in diff.
[2020-02-11T13:24:28.356Z] Congratulations!  All TOML source files changed here have valid syntax.
[2020-02-11T13:24:28.356Z] Congratulations!  Changelog CHANGELOG.md is well-formed.
[2020-02-11T13:24:28.356Z] Congratulations!  Changelog CHANGELOG.md dates are in descending order.
[2020-02-11T13:24:28.356Z] Congratulations!  No new tests were added to integration-cli.
[2020-02-11T13:24:28.356Z]
[2020-02-11T13:24:28.356Z] INFO Start validation with golang-ci-lint
[2020-02-11T13:24:28.356Z] INFO [config_reader] Used config file hack/validate/golangci-lint.yml
[2020-02-11T13:24:28.356Z] INFO [lintersdb] Active 14 linters: [deadcode goimports golint gosec gosimple govet ineffassign misspell staticcheck structcheck typecheck unconvert unused varcheck]
[2020-02-11T13:26:34.717Z] INFO [loader] Go packages loading at mode 575 (deps|files|imports|types_sizes|compiled_files|exports_file|name) took 1m52.850451791s
[2020-02-11T13:26:34.717Z] INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 460.576393ms
[2020-02-11T13:27:56.063Z] WARN [runner] Can't run linter goanalysis_metalinter: ctrlflow: failed prerequisites: [email protected]/docker/docker/vendor/github.com/moby/buildkit/frontend/dockerfile/instructions
[2020-02-11T13:27:56.063Z] INFO [runner] Issues before processing: 46, after processing: 0
[2020-02-11T13:27:56.063Z] INFO [runner] Processors filtering stat (out/in): cgo: 10/46, identifier_marker: 1/1, exclude: 1/1, nolint: 0/1, path_prettifier: 10/10, filename_unadjuster: 10/10, skip_files: 10/10, autogenerated_exclude: 1/10, skip_dirs: 10/10, exclude-rules: 1/1
[2020-02-11T13:27:56.063Z] INFO [runner] processing took 836.548µs with stages: nolint: 391.14µs, path_prettifier: 259.052µs, skip_dirs: 88.484µs, autogenerated_exclude: 57.043µs, identifier_marker: 18.843µs, cgo: 13.388µs, filename_unadjuster: 3.285µs, exclude-rules: 2.136µs, max_same_issues: 844ns, max_from_linter: 404ns, source_code: 350ns, diff: 306ns, skip_files: 295ns, path_shortener: 274ns, max_per_file_from_linter: 238ns, exclude: 237ns, uniq_by_line: 229ns
[2020-02-11T13:27:56.063Z] INFO [runner] linters took 1m32.380705124s with stages: goanalysis_metalinter: 1m14.106489491s, unused: 18.273264876s
[2020-02-11T13:27:56.063Z] INFO File cache stats: 1446 entries of total size 6.8MiB
[2020-02-11T13:27:56.063Z] INFO Memory: 1380 samples, avg is 744.1MB, max is 4376.5MB
[2020-02-11T13:27:56.063Z] INFO Execution took 3m25.699562852s

So , I think we should be good to go on this one

@thaJeztah
Copy link
Member

I'm bringing this one in to unblock other PR's

@thaJeztah thaJeztah merged commit 10425ed into moby:master Feb 11, 2020
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants